Add counter value when triggering ROTP#provisioning_uri #76
Conversation
|
Hi @wenderjean ! 👋 Thanks for your contribution (and delayed review of my part) 🤝 🍻 That's a great fix! In fact, when we generate the provisioning uri with otp counter previously used (and then with a value greater than zero), the authenticator app and server/backend must be in sync (i.e., with the same counter value). Please, could you fix the CI warnings and file conflicts? After that, @robertomiranda , I think we are ready to merge it ✅ 🏁 |
wenderjean
force-pushed
the
bugfix/add-counter-to-hotp-uri
branch
from
298c93e
to
bfc030e
Compare
wenderjean
force-pushed
the
bugfix/add-counter-to-hotp-uri
branch
from
bfc030e
to
09e44e4
Compare
wenderjean
force-pushed
the
bugfix/add-counter-to-hotp-uri
branch
from
09e44e4
to
c0e6775
Compare
|
I'll take a look on tests asap guys, I'm using a different PC right now for that reason I'm getting those issues. |
|
Thanks a lot @wenderjean 🍻 Let us know when you got tests working well 🤝 We will be glad to review it Thanks again for your effort on it 🥇 |
wenderjean
force-pushed
the
bugfix/add-counter-to-hotp-uri
branch
from
c0e6775
to
7af39ca
Compare
| assert_match %r{^otpauth://totp/Example\:roberto\?secret=\w{32}&issuer=Example$}, @visitor.provisioning_uri("roberto", issuer: "Example") | ||
| account = %r{ | ||
| ^otpauth://totp/Example\:roberto\?secret=\w{32}&issuer=Example$ | ||
| }x |
There was a problem hiding this comment.
The trick for multi-line regex content: }x
|
All good @pedrofurtado :) |
|
Thank you for your effort on it, @wenderjean ! 🤝 Our team is planning (especially me and @robertomiranda) to release this and some other improvements/bugfixes in a new release soon 🎉 |
Related to: #74
Changes
self.otp_counterwhen callingROTP#provisioning_uriin order to have it on the final URIConcerns
Note.: Taking a look at the source it doesn't seem we're caring about the
houndci-botfor line length metrics. Did we enablehoundci-botrecently?