hop_size is back #68
Closed
hop_size is back #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorshi
reviewed
Jun 24, 2021
| @@ -133,7 +132,7 @@ def frame_audio( | |||
| def get_audio_embedding( | |||
| audio: Tensor, | |||
| model: torch.nn.Module, | |||
| frame_rate: float, | |||
| hop_size: float, | |||
There was a problem hiding this comment.
Since discussions to allow hop_size to be defined by participants, let's just assign a default value for this? Say 25ms?
There was a problem hiding this comment.
Also do we want this value to be in ms as opposed to seconds?
|
@turian -- should we pull out all the models from this repo since we have the separate repo for the baseline now? |
|
@jorshi "should we pull out all the models from this repo since we have the separate repo for the baseline now?" yeah |
|
Closing this since the baseline has been moved to a new repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.