Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of P tag in signup forms leads to broken layout #1197

Closed
andriytyurnikov opened this issue Jul 14, 2011 · 2 comments
Closed

Usage of P tag in signup forms leads to broken layout #1197

andriytyurnikov opened this issue Jul 14, 2011 · 2 comments

Comments

@andriytyurnikov
Copy link
Contributor

https://github.com/plataformatec/devise/blob/master/app/views/devise/registrations/new.html.erb
When we have fields with errors, layout is broken
no DIV tags are allowed inside P tags - browsers brake them.

And according to rails/rails#2058
this will not be fixed.

So it looks like we need to change forms, to add proc, or to notify users of devise about issue

@josevalim
Copy link
Contributor

Could you please send a devise pull request changing all forms to use <div> instead of <p>?

@andriytyurnikov
Copy link
Contributor Author

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants