Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Rails 4.2 (beta) #3159

Closed
trinode opened this issue Aug 20, 2014 · 12 comments
Closed

Issue with Rails 4.2 (beta) #3159

trinode opened this issue Aug 20, 2014 · 12 comments

Comments

@trinode
Copy link

trinode commented Aug 20, 2014

Hi there,

I'm not sure what has changed / will be changing in 4.2 but it looks like merge! is no longer available on some objects:-

if I have
devise_for :users
I get the following errors:-

NoMethodError: undefined method `merge!' for #<ActionDispatch::Routing::Mapper::Scope:0x000000062cded0>
/usr/local/rvm/gems/ruby-2.1.2/gems/devise-3.3.0/lib/devise/rails/routes.rb:457:in `ensure in with_devise_exclusive_scope'
/usr/local/rvm/gems/ruby-2.1.2/gems/devise-3.3.0/lib/devise/rails/routes.rb:457:in `with_devise_exclusive_scope'
/usr/local/rvm/gems/ruby-2.1.2/gems/devise-3.3.0/lib/devise/rails/routes.rb:248:in `block (2 levels) in devise_for'
/usr/local/rvm/gems/ruby-2.1.2/gems/devise-3.3.0/lib/devise/rails/routes.rb:351:in `block in devise_scope'
/usr/local/rvm/gems/ruby-2.1.2/gems/actionpack-4.2.0.beta1/lib/action_dispatch/routing/mapper.rb:932:in `block in constraints'
/usr/local/rvm/gems/ruby-2.1.2/gems/actionpack-4.2.0.beta1/lib/action_dispatch/routing/mapper.rb:808:in `scope'
/usr/local/rvm/gems/ruby-2.1.2/gems/actionpack-4.2.0.beta1/lib/action_dispatch/routing/mapper.rb:932:in `constraints'
/usr/local/rvm/gems/ruby-2.1.2/gems/devise-3.3.0/lib/devise/rails/routes.rb:350:in `devise_scope'
/usr/local/rvm/gems/ruby-2.1.2/gems/devise-3.3.0/lib/devise/rails/routes.rb:247:in `block in devise_for'
/usr/local/rvm/gems/ruby-2.1.2/gems/devise-3.3.0/lib/devise/rails/routes.rb:223:in `each'
/usr/local/rvm/gems/ruby-2.1.2/gems/devise-3.3.0/lib/devise/rails/routes.rb:223:in `devise_for'
@Fudoshiki
Copy link
Contributor

#3153

@trinode
Copy link
Author

trinode commented Aug 20, 2014

Ahh, thanks, I looked for open issues, I didn't see the pull request! I'll track that pull request. I'm not sure if I should close this or leave it open so that other's see the pull request.

@Fudoshiki
Copy link
Contributor

waiting for merge, then close

@trinode trinode changed the title Issue with 4.2 (beta) Issue with Rails 4.2 (beta) Aug 20, 2014
@wafcio
Copy link

wafcio commented Aug 20, 2014

I have found another issue with devise and rails 4.2 on branch lm-rails-4-2 devise should have dependency for https://github.com/plataformatec/responders because without this gem devise doesn't work.

@lucasmazza
Copy link
Contributor

Everything should be handled over #3153, so just track that Pull Request and if you are testing the 4.2 branch please report any problem that wasn't discussed before on that thread. Please do not open duplicated issues regarding Rails 4.2+.

@trinode
Copy link
Author

trinode commented Aug 20, 2014

@lucasmazza I came here because I'm a user of devise, I had an issue so I checked open issues, there was none, so I opened one. I can imagine another one getting opened shortly, normally the issue stays open until it's fixed and Your commit would mention the fix in the commit, which should automatically close the issue when it's actually fixed ie "Add Rails 4.2 compatibility - fixes #[issue_no]".

https://help.github.com/articles/closing-issues-via-commit-messages

It's not my repo and you can run it the way you choose, of course. I just think that's confusing for people like myself who came to check if the issue was being worked on / reported.

@nextbase
Copy link

Still doesn't work for me.

@jaythaceo
Copy link

Add this to gem file instead. run bundle install, rake db:migrate.. worked for me
" USE IN PRODUCTION at OWN RISK"
gem 'devise', :git => 'https://github.com/plataformatec/devise.git', :branch => 'lm-rails-4-2'

@rafaelfranca
Copy link
Collaborator

@jaythaceo or you can just use devise 3.4.1

@jaythaceo
Copy link

Thanks a lot

@tunsmart
Copy link

wow, thanks @rafaelfranca , 3.4.1 worked perfectly

@amritdeep
Copy link

Thanks Guys, It help me lot. Devise 3.4.1 work perfectly for rails 4.2.5.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

9 participants