Internationalise all of the views. #4057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- i18nify confirmation views - Internationalise confirmation_instructions mailer. - Internationalise password_change mailer. - Internationalise password_change, reset_password and unlock mailers. Tidied up confirmation instructions mailer. - Internationalise passwords views. - Internationalise registration views - Internationalise session views - Internationalise shared links - Internationalise unlock views - Internationalise hint for passwords#edit view - Internationalise simple form views for confirmations and passwords - Internationalise simple form views for registrations, sessions and unlocks - Update en.yml so that keys are in alphabetical order. - Internationalise markerb templates
|
Hi @Galkon, Thank you but we don't plan to accept this PR because the views were always meant to be a starting point and not a final version. Also, adding translation calls to them make the views much harder to understand to everyone not using i18n. Please see #2058 #1642 #1983 #1989 #3684 and many others similar issues/pull requests for the reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR is to figure out if there is much of an appetite for internationalising everything. I'm going through the process of doing this at the moment in a rails application so thought it might be worth while contributing it back so that others don't have to.
TODO:
At the moment the approach I'm taking is to have everything as a seperate key even if the content is the same as you can see in this example here. This is to increase the flexibility incase users of the gem want to customise the button text for example.
Thanks :)