-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Humanize invalid login error message and downcase authentication keys #5454
base: main
Are you sure you want to change the base?
Conversation
@carlosantoniodasilva or @tegon would you be willing to merge this? It's just error string updates and was previously merged into the V5 RC branch. |
If it was/is in the v5 branch, it's because it's technically "breaking" in some way and it's hard to update those things in patch/minor versions sometimes. That said, v5 isn't dead, we will release a major version at some point, there's just some other things that need to be taken care of first. I'll keep this one open and assigned to me to circle back on it, thanks. |
@carlosantoniodasilva this is purely a string change for error message (correct capitalisation of words) so I don't think it's a breaking change, I think it was just merged into v5 rather than main in the expectation that that was the primary development branch at the time? Appreciate you looking at it though! |
@marivaldo thanks for reviewing. Have made the suggested changes. |
Co-authored-by: Marivaldo Cavalheiro <marivaldo@gmail.com>
d44d238
to
93bdf56
Compare
@carlosantoniodasilva @marivaldo rebased this on the latest changes, could you take a look and enable CI? |
Re-opening this #4834 on main since development of the v5 rc branch seems to have stalled.