Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humanize invalid login error message and downcase authentication keys #5454

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

baarkerlounger
Copy link

Re-opening this #4834 on main since development of the v5 rc branch seems to have stalled.

@baarkerlounger
Copy link
Author

@carlosantoniodasilva or @tegon would you be willing to merge this? It's just error string updates and was previously merged into the V5 RC branch.

@carlosantoniodasilva carlosantoniodasilva self-assigned this Mar 16, 2022
@carlosantoniodasilva
Copy link
Member

If it was/is in the v5 branch, it's because it's technically "breaking" in some way and it's hard to update those things in patch/minor versions sometimes.

That said, v5 isn't dead, we will release a major version at some point, there's just some other things that need to be taken care of first.

I'll keep this one open and assigned to me to circle back on it, thanks.

@baarkerlounger baarkerlounger changed the title Humanize invalid login error message and downsize authentication keys Humanize invalid login error message and downcase authentication keys Mar 31, 2022
@baarkerlounger
Copy link
Author

@carlosantoniodasilva this is purely a string change for error message (correct capitalisation of words) so I don't think it's a breaking change, I think it was just merged into v5 rather than main in the expectation that that was the primary development branch at the time?

Appreciate you looking at it though!

lib/devise/failure_app.rb Outdated Show resolved Hide resolved
@baarkerlounger
Copy link
Author

@marivaldo thanks for reviewing. Have made the suggested changes.

baarkerlounger and others added 2 commits May 3, 2023 16:50
Co-authored-by: Marivaldo Cavalheiro <marivaldo@gmail.com>
@baarkerlounger
Copy link
Author

@carlosantoniodasilva @marivaldo rebased this on the latest changes, could you take a look and enable CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants