New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a dedicated ActiveSupport::Deprecation #5583
Conversation
Rails 7.1 will deprecate using the singleton ActiveSupport::Deprecation instance. This defines one for the gem and uses it.
ec81a34
to
882dd70
Compare
Hope to see these depreciation issues fixed before Rails 7.1 official release. I was playing around with MRSK. Doesn't seem plausible just yet. |
@RailsCod3rFuture I'm not sure how this relates to the changes here? You mean the deprecations are causing you trouble with MRSK? |
The rails server doesn't start on rails 7.1 as a result of the ActiveSupport::Deprecation instance. If someone else can check on their end for an r 7.1. app, that should confirm the symptoms that I'm experiencing. Thanks! |
@RailsCod3rFuture so I'd guess this is not a Devise problem, but an MRSK problem? I mean, I see no reason why the deprecations would prevent Devise from working. (I'm not saying we aren't gonna fix it, just mentioning it shouldn't break stuff like that imo.) |
This is the exception that I receive while launching the rails app for 7.1
|
I think you're just seeing the deprecation just above your real issue with polyamorous. |
Good catch. I'll probably have to reach out to the ransack team on that note....see if they have any solutions or knowledge of this issue. |
@@ -521,8 +521,12 @@ def self.secure_compare(a, b) | |||
res == 0 | |||
end | |||
|
|||
def self.deprecator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to register the deprecator in the application deprecator. We want users to be able to silence the deprecations in their apps, or change the behavior to use notifications for example. Can you do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Use a dedicated ActiveSupport::Deprecation
Use a dedicated ActiveSupport::Deprecation
Use a dedicated ActiveSupport::Deprecation
Rails 7.1 will deprecate using the singleton ActiveSupport::Deprecation instance (rails/rails#47354). This defines one for the gem and uses it.