-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support to EOL rubies and Rails #5600
Drop support to EOL rubies and Rails #5600
Conversation
71b0468
to
a231897
Compare
All Ruby 2.x are EOL now.
It's EOL but the current versions of Rails are still supporting it, so it makes sense for us to keep supporting it as well. And it doesn't give us any extra maintenance burden as older versions have been doing.
a231897
to
72b421e
Compare
Also change back to run CI on ubuntu-latest which should work with all Ruby versions supported now.
They were added to support an old/deprecated feature of Rails, as the message was saying, we can now remove them from the code as well.
Thanks @rafaelfranca! I was hesitant to drop support and have to go to a 5x release, but it's probably time, there's a few other potential breaking changes we can then include to move things forward. I've branched out a |
@carlosantoniodasilva I'm not sure if you were keeping support to those old versions by design, but maybe it is time for us to let it go. All tests on Ruby < 2.7 were failing.