Add ignore_period option to .confirm #5677
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When set to true, the user will be confirmed without checking Devise.confirm_within.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi and thank you for all your work, I've been using Devise in all my projects since forever, but this is my first contribution.
In most if not all projects, I end up needing this for an admin panel or backoffice, where an admin can mark an email as confirmed manually. Calling
.confirmwill not work if the period is expired. I know it is possible to resend the confirmation link and so reset the period, but for some reason or other, this is a flow support teams end up needing. It's very easy to implement of course, but I think it'd be nice to have it in the library, instead of going to the database behind the library's back.