Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 4 support #36

Merged
merged 8 commits into from Mar 1, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
@@ -1,2 +1,2 @@
.bundle
Gemfile.lock
*.lock
12 changes: 12 additions & 0 deletions .travis.yml
@@ -0,0 +1,12 @@
language: ruby
rvm:
- 1.8.7
- 1.9.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is good to add 1.8.7 in the build matrix only to 3.2.x

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add 1.8.7 to rvm and adding this should do it:

matrix:
  exclude:
    - rvm: 1.8.7
      gemfile: Gemfile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 08b092f

- 2.0.0
gemfile:
- Gemfile
- gemfiles/Gemfile-rails.3.2.x
matrix:
exclude:
- rvm: 1.8.7
gemfile: gemfiles/Gemfile.rails-3.2.x
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey guys, I did a mistake here. It should be

matrix:
  exclude:
    - rvm: 1.8.7
      gemfile: Gemfile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nevermind. It has beed fixed already.

5 changes: 5 additions & 0 deletions Gemfile
@@ -1,3 +1,8 @@
source :rubygems

gemspec

gem 'actionpack', '~> 4.0.0.beta1'
gem 'activesupport', '~> 4.0.0.beta1'
gem 'mocha', '~> 0.13.2'
gem 'rake'
8 changes: 8 additions & 0 deletions gemfiles/Gemfile-rails.3.2.x
@@ -0,0 +1,8 @@
source 'https://rubygems.org'

gem 'has_scope', :path => '..'

gem 'actionpack', '~> 3.2.0'
gem 'activesupport', '~> 3.2.0'
gem 'mocha', '~> 0.13.2'
gem 'rake'
12 changes: 2 additions & 10 deletions has_scope.gemspec
Expand Up @@ -25,14 +25,6 @@ Gem::Specification.new do |s|
"README.md"
]

s.add_runtime_dependency "actionpack", "~> 3.2.0"
s.add_runtime_dependency "activesupport", "~> 3.2.0"
s.add_development_dependency "mocha", "~> 0.12.0"
s.add_development_dependency "rake"
if RUBY_VERSION < "1.9"
s.add_development_dependency "rdoc"
s.add_development_dependency "ruby-debug"
else
s.add_development_dependency "test-unit"
end
s.add_runtime_dependency "actionpack", ">= 3.2.0"
s.add_runtime_dependency "activesupport", ">= 3.2.0"
end
4 changes: 2 additions & 2 deletions test/test_helper.rb
Expand Up @@ -3,7 +3,7 @@

Bundler.setup
require 'test/unit'
require 'mocha'
require 'mocha/setup'

# Configure Rails
ENV["RAILS_ENV"] = "test"
Expand All @@ -17,7 +17,7 @@

HasScope::Routes = ActionDispatch::Routing::RouteSet.new
HasScope::Routes.draw do
match '/:controller(/:action(/:id))'
get '/:controller(/:action(/:id))'
end

class ApplicationController < ActionController::Base
Expand Down