New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 4 support #36
Merged
Merged
Rails 4 support #36
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b7e153e
Update ignores to exclude all lock files.
spectator 6624791
Main Gemfile is for Rails 4 now.
spectator 2585d60
Cleanup gemspec from stuff moved into gemfiles.
spectator 7bcfdcc
Gemfile for Rails 3.2.
spectator d34d079
Let's add this project to Travis.
spectator d963a21
Mocha is locked at ~> 0.13.2 to have compatibility with minitest, so …
spectator 9c59536
Explicitly set HTTP request type in routes since Rails 4 requires tha…
spectator 08b092f
Add Ruby 1.8.7 to build matrix.
spectator File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
.bundle | ||
Gemfile.lock | ||
*.lock |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
language: ruby | ||
rvm: | ||
- 1.8.7 | ||
- 1.9.3 | ||
- 2.0.0 | ||
gemfile: | ||
- Gemfile | ||
- gemfiles/Gemfile-rails.3.2.x | ||
matrix: | ||
exclude: | ||
- rvm: 1.8.7 | ||
gemfile: gemfiles/Gemfile.rails-3.2.x | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hey guys, I did a mistake here. It should be matrix:
exclude:
- rvm: 1.8.7
gemfile: Gemfile There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, nevermind. It has beed fixed already. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,8 @@ | ||
source :rubygems | ||
|
||
gemspec | ||
|
||
gem 'actionpack', '~> 4.0.0.beta1' | ||
gem 'activesupport', '~> 4.0.0.beta1' | ||
gem 'mocha', '~> 0.13.2' | ||
gem 'rake' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
source 'https://rubygems.org' | ||
|
||
gem 'has_scope', :path => '..' | ||
|
||
gem 'actionpack', '~> 3.2.0' | ||
gem 'activesupport', '~> 3.2.0' | ||
gem 'mocha', '~> 0.13.2' | ||
gem 'rake' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is good to add 1.8.7 in the build matrix only to 3.2.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add 1.8.7 to
rvm
and adding this should do it:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 08b092f