Default step of "any" for number input

heartcombo · Mar 16, 2011 · 5aa4320 · 5aa4320
1 parent 3c07619
commit 5aa4320
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/simple_form/inputs/numeric_input.rb b/lib/simple_form/inputs/numeric_input.rb
@@ -4,7 +4,7 @@ class NumericInput < Base
       def input
         input_html_options[:type] ||= "number"
         input_html_options[:size] ||= SimpleForm.default_input_size
-        input_html_options[:step] ||= 1 if integer?
+        input_html_options[:step] ||= integer? ? 1 : "any"
         infer_attributes_from_validations!
         @builder.text_field(attribute_name, input_html_options)
       end

diff --git a/test/inputs_test.rb b/test/inputs_test.rb
@@ -276,9 +276,9 @@ def with_input_for(object, attribute_name, type, options={})
     assert_select 'input[max=119]'
   end
 
-  test 'input should infer step value only from integer attribute' do
+  test 'input should have step value of any except for integer attribute' do
     with_input_for @validating_user, :age, :float
-    assert_no_select 'input[step]'
+    assert_select 'input[step="any"]'
 
     with_input_for @validating_user, :age, :integer
     assert_select 'input[step=1]'