Allow collection input to accept a collection of symbols, closes #33

heartcombo · Aug 14, 2010 · cf99793 · cf99793
1 parent 7626fa4
commit cf99793
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/simple_form/inputs/collection_input.rb b/lib/simple_form/inputs/collection_input.rb
@@ -46,7 +46,7 @@ def detect_collection_methods(collection, options)
           label, value = :first, :last
         when Integer
           label, value = :to_s, :to_i
-        when String, NilClass
+        when String, Symbol, NilClass
           label, value = :to_s, :to_s
         end
 

diff --git a/test/inputs_test.rb b/test/inputs_test.rb
@@ -327,6 +327,13 @@ def with_input_for(object, attribute_name, type, options={})
     assert_select 'label.collection_radio', 'CARLOS'
   end
 
+  test 'input should allow symbols for collections' do
+    with_input_for @user, :name, :select, :collection => [:jose, :carlos]
+    assert_select 'select.select#user_name'
+    assert_select 'select option[value=jose]', 'jose'
+    assert_select 'select option[value=carlos]', 'carlos'
+  end
+
   # With no object
   test 'input should be generated properly when object is not present' do
     with_input_for :project, :name, :string