Fix Travis CI #1682
Merged
Fix Travis CI #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is supposed to fix the following error on Travis:
```
4: from /home/travis/.rvm/gems/ruby-2.6.3/bin/ruby_executable_hooks:24:in `<main>'
3: from /home/travis/.rvm/gems/ruby-2.6.3/bin/ruby_executable_hooks:24:in `eval'
2: from /home/travis/.rvm/rubies/ruby-2.6.3/bin/bundle:23:in `<main>'
1: from /home/travis/.rvm/rubies/ruby-2.6.3/lib/ruby/site_ruby/2.6.0/rubygems.rb:294:in `activate_bin_path'
/home/travis/.rvm/rubies/ruby-2.6.3/lib/ruby/site_ruby/2.6.0/rubygems.rb:275:in `find_spec_for_exe':
Could not find 'bundler' (1.17.3) required by your /home/travis/build/plataformatec/simple_form/Gemfile.lock.
(Gem::GemNotFoundException)
```
Ref: rubygems/bundler#6882 (comment)
Also, the CI can no longer build for jruby 9.1.17.0 due this error:
```
NoMethodError: undefined method `[]' for nil:NilClass
/home/travis/.rvm/gems/jruby-9.1.17.0/gems/bundler-2.1.2/lib/bundler/source/git/git_proxy.rb:90:in `version'
/home/travis/.rvm/gems/jruby-9.1.17.0/gems/bundler-2.1.2/lib/bundler/source/git/git_proxy.rb:147:in `block in copy_to'
org/jruby/RubyDir.java:323:in `chdir'
/home/travis/.rvm/gems/jruby-9.1.17.0/gems/bundler-2.1.2/lib/bundler/shared_helpers.rb:52:in `block in chdir'
/home/travis/.rvm/rubies/jruby-9.1.17.0/lib/ruby/stdlib/monitor.rb:214:in `mon_synchronize'
```
I'm not sure what to do to fix that, maybe we could remove this from our
build and keep only the last version of jruby?
That's what this commit does 馃檲.
|
I'm guessing the JRuby failure is due to incompatibility between newer versions of bundler and old versions of JRuby. Regardless, it seems like the tests are also failing in 9.2, so I think we can look into it separately later. |
tegon
approved these changes
Dec 26, 2019
rafaelfranca
approved these changes
Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is supposed to fix the following error on Travis:
Ref: rubygems/bundler#6882 (comment)
Also, the CI can no longer build for jruby 9.1.17.0 due this error:
I'm not sure what to do to fix that, maybe we could remove this from our build and keep only the last version of jruby?
That's what this commit does 馃檲.