Copy edited error_notification.default_message.

[pcantrell]

The previous phrasing — "Some errors were found, please take a look:" — is bad English for several reasons:

• It's grammatically incorrect. "Some errors were found" and "please take a look" are independent clauses, so they can't be joined by a comma. You must either use a semicolon ("Some errors were found; please take a look:") or turn them into two separate sentences ("Some errors were found. Please take a look:").

• The passive voice of "errors were found" seems evasive and wishy-washy. Error found where? By whom? It's unpleasantly reminiscent of "mistakes were made."

I've proposed an entirely different wording which is both stronger and more concise. If you don't like it, you should at least fix the punctuation error (making it "Some errors were found. Please take a look:").

P.S. Thanks for the excellent project.

[travisbot]

This pull request passes (merged ca1868a into 767dfae).

[carlosantoniodasilva]

@pcantrell thank you for your pull request, and sorry for our wording, as non native speakers, sometimes it is hard to find the right words :).

I kinda dislike the word "fix", though: Please fix the problems below:. I like the idea of being concise, but it might sound too strong for the point of view of a user maybe? What about using review or some other similar word?

Please review the problems below:

The sentence used in old errors_message_for was: There were problems with the following fields:

Thanks!

[pcantrell]

I really like "Please review the problems below." That sounds nice.

I didn't realize you're non-native speakers. These are mistakes that we natives make too!

On Apr 28, 2012, at 7:36 AM, Carlos Antonio da Silva wrote:

@pcantrell thank you for your pull request, and sorry for our wording, as non native speakers, sometimes it is hard to find the right words :).

I kinda dislike the work "fix", though: Please fix the problems below:. I like the idea of being concise, but it might sound too strong for the point of view of a user maybe? What about using review or some other similar word?

Please review the problems below:

The sentence used in old errors_message_for was: There were problems with the following fields:

Thanks!

---

Reply to this email directly or view it on GitHub:
#550 (comment)

[carlosantoniodasilva]

@pcantrell great, so we agree on Please review the problems below :). Would you mind updating the pull request, so I can apply? Thanks.

[pcantrell]

Pull request updated!

[carlosantoniodasilva]

Awesome, thanks!