Skip to content

Kindling CI

Kindling CI #4

Triggered via pull request November 29, 2023 19:53
Status Success
Total duration 4m 21s
Artifacts

hearth.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

28 warnings
rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
very complex type used. Consider factoring parts into `type` definitions: core/runtime/src/runtime.rs#L63
warning: very complex type used. Consider factoring parts into `type` definitions --> core/runtime/src/runtime.rs:63:15 | 63 | finalize: Box<dyn FnOnce(Box<dyn Any>, &mut RuntimeBuilder) + Send>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
usage of `contains_key` followed by `insert` on a `HashMap`: core/runtime/src/connection.rs#L100
warning: usage of `contains_key` followed by `insert` on a `HashMap` --> core/runtime/src/connection.rs:100:13 | 100 | / if exports.contains_key(&id) { 101 | | // cap is already exported, so drop this reference 102 | | table.dec_ref(handle).unwrap(); 103 | | } else { ... | 112 | | self.send_local_op(op); 113 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry = note: `#[warn(clippy::map_entry)]` on by default help: try | 100 ~ if let std::collections::hash_map::Entry::Vacant(e) = exports.entry(id) { 101 + // cap needs to be exported 102 + let cap = table.wrap_handle(handle).unwrap(); 103 + let perms = cap.get_permissions().bits(); 104 + let perms = hearth_schema::Permissions::from_bits_retain(perms); 105 + let op = LocalCapOperation::DeclareCap { id, perms }; 106 + let revoked = false; 107 + let export = Export { cap, revoked }; 108 + e.insert(export); 109 + self.send_local_op(op); 110 + } else { 111 + // cap is already exported, so drop this reference 112 + table.dec_ref(handle).unwrap(); 113 + } |
returning the result of a `let` binding from a block: core/runtime/src/connection.rs#L89
warning: returning the result of a `let` binding from a block --> core/runtime/src/connection.rs:89:9 | 87 | let conn = Arc::new(conn); | -------------------------- unnecessary `let` binding 88 | 89 | conn | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 87 ~ 88 | 89 ~ Arc::new(conn) |
very complex type used. Consider factoring parts into `type` definitions: core/runtime/src/runtime.rs#L63
warning: very complex type used. Consider factoring parts into `type` definitions --> core/runtime/src/runtime.rs:63:15 | 63 | finalize: Box<dyn FnOnce(Box<dyn Any>, &mut RuntimeBuilder) + Send>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
usage of `contains_key` followed by `insert` on a `HashMap`: core/runtime/src/connection.rs#L100
warning: usage of `contains_key` followed by `insert` on a `HashMap` --> core/runtime/src/connection.rs:100:13 | 100 | / if exports.contains_key(&id) { 101 | | // cap is already exported, so drop this reference 102 | | table.dec_ref(handle).unwrap(); 103 | | } else { ... | 112 | | self.send_local_op(op); 113 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry = note: `#[warn(clippy::map_entry)]` on by default help: try | 100 ~ if let std::collections::hash_map::Entry::Vacant(e) = exports.entry(id) { 101 + // cap needs to be exported 102 + let cap = table.wrap_handle(handle).unwrap(); 103 + let perms = cap.get_permissions().bits(); 104 + let perms = hearth_schema::Permissions::from_bits_retain(perms); 105 + let op = LocalCapOperation::DeclareCap { id, perms }; 106 + let revoked = false; 107 + let export = Export { cap, revoked }; 108 + e.insert(export); 109 + self.send_local_op(op); 110 + } else { 111 + // cap is already exported, so drop this reference 112 + table.dec_ref(handle).unwrap(); 113 + } |
returning the result of a `let` binding from a block: core/runtime/src/connection.rs#L89
warning: returning the result of a `let` binding from a block --> core/runtime/src/connection.rs:89:9 | 87 | let conn = Arc::new(conn); | -------------------------- unnecessary `let` binding 88 | 89 | conn | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 87 ~ 88 | 89 ~ Arc::new(conn) |
function `hash_map_to_ordered_vec` is never used: main/ctl/src/main.rs#L105
warning: function `hash_map_to_ordered_vec` is never used --> main/ctl/src/main.rs:105:4 | 105 | fn hash_map_to_ordered_vec<K: Copy + Ord, V>(map: HashMap<K, V>) -> Vec<(K, V)> { | ^^^^^^^^^^^^^^^^^^^^^^^
function `get_daemon` is never used: main/ctl/src/main.rs#L99
warning: function `get_daemon` is never used --> main/ctl/src/main.rs:99:10 | 99 | async fn get_daemon() -> CommandResult<Connection> { | ^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
function `hash_map_to_ordered_vec` is never used: main/ctl/src/main.rs#L105
warning: function `hash_map_to_ordered_vec` is never used --> main/ctl/src/main.rs:105:4 | 105 | fn hash_map_to_ordered_vec<K: Copy + Ord, V>(map: HashMap<K, V>) -> Vec<(K, V)> { | ^^^^^^^^^^^^^^^^^^^^^^^
function `get_daemon` is never used: main/ctl/src/main.rs#L99
warning: function `get_daemon` is never used --> main/ctl/src/main.rs:99:10 | 99 | async fn get_daemon() -> CommandResult<Connection> { | ^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (ubuntu-latest): main/ctl/src/main.rs#L99
function `get_daemon` is never used
build (ubuntu-latest): main/ctl/src/main.rs#L105
function `hash_map_to_ordered_vec` is never used
build (ubuntu-latest)
`hearth-ctl` (bin "hearth-ctl" test) generated 2 warnings
build (macos-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (macos-latest): main/ctl/src/main.rs#L99
function `get_daemon` is never used
build (macos-latest): main/ctl/src/main.rs#L105
function `hash_map_to_ordered_vec` is never used
build (macos-latest)
`hearth-ctl` (bin "hearth-ctl" test) generated 2 warnings (2 duplicates)
test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
test: main/ctl/src/main.rs#L99
function `get_daemon` is never used
test: main/ctl/src/main.rs#L105
function `hash_map_to_ordered_vec` is never used
test
`hearth-ctl` (bin "hearth-ctl" test) generated 2 warnings