kindling-host: renderer bindings #668
pr.yml
on: pull_request
hearth-test
1m 42s
hearth-clippy
1m 6s
hearth-rustfmt
14s
kindling-build
30s
kindling-clippy
33s
kindling-rustfmt
15s
Matrix: hearth-build
Annotations
51 warnings
hearth-rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, LoliGothick/rustfmt-check@master. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
hearth-rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
hearth-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
hearth-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
hearth-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
hearth-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
kindling-rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, LoliGothick/rustfmt-check@master. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
kindling-rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
kindling-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
kindling-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
kindling-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
kindling-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
kindling-build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, Swatinem/rust-cache@v2.2.0, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
kindling-build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
kindling-clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: Swatinem/rust-cache@v2.2.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
accessing first element with `resp.1.get(0)`:
kindling/host/src/canvas.rs#L49
warning: accessing first element with `resp.1.get(0)`
--> kindling/host/src/canvas.rs:49:18
|
49 | cap: resp.1.get(0).unwrap().clone(),
| ^^^^^^^^^^^^^ help: try: `resp.1.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
|
accessing first element with `resp.1.get(0)`:
kindling/host/src/canvas.rs#L49
warning: accessing first element with `resp.1.get(0)`
--> kindling/host/src/canvas.rs:49:18
|
49 | cap: resp.1.get(0).unwrap().clone(),
| ^^^^^^^^^^^^^ help: try: `resp.1.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
|
accessing first element with `DEBUG_DRAW_FACTORY
.request((), &[])
.1.get(0)`:
kindling/host/src/debug_draw.rs#L51
warning: accessing first element with `DEBUG_DRAW_FACTORY
.request((), &[])
.1.get(0)`
--> kindling/host/src/debug_draw.rs:51:18
|
51 | cap: DEBUG_DRAW_FACTORY
| __________________^
52 | | .request((), &[])
53 | | .1
54 | | .get(0)
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
help: try
|
51 ~ cap: DEBUG_DRAW_FACTORY
52 + .request((), &[])
53 + .1.first()
|
|
accessing first element with `DEBUG_DRAW_FACTORY
.request((), &[])
.1.get(0)`:
kindling/host/src/debug_draw.rs#L51
warning: accessing first element with `DEBUG_DRAW_FACTORY
.request((), &[])
.1.get(0)`
--> kindling/host/src/debug_draw.rs:51:18
|
51 | cap: DEBUG_DRAW_FACTORY
| __________________^
52 | | .request((), &[])
53 | | .1
54 | | .get(0)
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
help: try
|
51 ~ cap: DEBUG_DRAW_FACTORY
52 + .request((), &[])
53 + .1.first()
|
|
accessing first element with `resp.1.get(0)`:
kindling/host/src/terminal.rs#L47
warning: accessing first element with `resp.1.get(0)`
--> kindling/host/src/terminal.rs:47:18
|
47 | cap: resp.1.get(0).unwrap().clone(),
| ^^^^^^^^^^^^^ help: try: `resp.1.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
|
accessing first element with `resp.1.get(0)`:
kindling/host/src/terminal.rs#L47
warning: accessing first element with `resp.1.get(0)`
--> kindling/host/src/terminal.rs:47:18
|
47 | cap: resp.1.get(0).unwrap().clone(),
| ^^^^^^^^^^^^^ help: try: `resp.1.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
|
accessing first element with `resp.get(0)`:
kindling/host/src/time.rs#L56
warning: accessing first element with `resp.get(0)`
--> kindling/host/src/time.rs:56:35
|
56 | Self(RequestResponse::new(resp.get(0).unwrap().clone()))
| ^^^^^^^^^^^ help: try: `resp.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
|
accessing first element with `resp.get(0)`:
kindling/host/src/time.rs#L56
warning: accessing first element with `resp.get(0)`
--> kindling/host/src/time.rs:56:35
|
56 | Self(RequestResponse::new(resp.get(0).unwrap().clone()))
| ^^^^^^^^^^^ help: try: `resp.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
|
accessing first element with `resp.get(0)`:
kindling/host/src/time.rs#L77
warning: accessing first element with `resp.get(0)`
--> kindling/host/src/time.rs:77:35
|
77 | Self(RequestResponse::new(resp.get(0).unwrap().clone()))
| ^^^^^^^^^^^ help: try: `resp.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
|
accessing first element with `resp.get(0)`:
kindling/host/src/time.rs#L77
warning: accessing first element with `resp.get(0)`
--> kindling/host/src/time.rs:77:35
|
77 | Self(RequestResponse::new(resp.get(0).unwrap().clone()))
| ^^^^^^^^^^^ help: try: `resp.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
|
hearth-clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: Swatinem/rust-cache@v2.2.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
use of a fallible conversion when an infallible one could be used:
core/ipc/src/lib.rs#L35
warning: use of a fallible conversion when an infallible one could be used
--> core/ipc/src/lib.rs:35:28
|
35 | match path.clone().try_into() {
| ^^^^^^^^ help: use: `into`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
|
use of a fallible conversion when an infallible one could be used:
core/ipc/src/lib.rs#L44
warning: use of a fallible conversion when an infallible one could be used
--> core/ipc/src/lib.rs:44:15
|
44 | match TryInto::<PathBuf>::try_into(path.clone()) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `Into::into`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
|
use of a fallible conversion when an infallible one could be used:
core/ipc/src/lib.rs#L35
warning: use of a fallible conversion when an infallible one could be used
--> core/ipc/src/lib.rs:35:28
|
35 | match path.clone().try_into() {
| ^^^^^^^^ help: use: `into`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
|
use of a fallible conversion when an infallible one could be used:
core/ipc/src/lib.rs#L44
warning: use of a fallible conversion when an infallible one could be used
--> core/ipc/src/lib.rs:44:15
|
44 | match TryInto::<PathBuf>::try_into(path.clone()) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `Into::into`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
|
function `get_daemon` is never used:
main/ctl/src/main.rs#L99
warning: function `get_daemon` is never used
--> main/ctl/src/main.rs:99:10
|
99 | async fn get_daemon() -> CommandResult<Connection> {
| ^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
function `hash_map_to_ordered_vec` is never used:
main/ctl/src/main.rs#L105
warning: function `hash_map_to_ordered_vec` is never used
--> main/ctl/src/main.rs:105:4
|
105 | fn hash_map_to_ordered_vec<K: Copy + Ord, V>(map: HashMap<K, V>) -> Vec<(K, V)> {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
function `get_daemon` is never used:
main/ctl/src/main.rs#L99
warning: function `get_daemon` is never used
--> main/ctl/src/main.rs:99:10
|
99 | async fn get_daemon() -> CommandResult<Connection> {
| ^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
function `hash_map_to_ordered_vec` is never used:
main/ctl/src/main.rs#L105
warning: function `hash_map_to_ordered_vec` is never used
--> main/ctl/src/main.rs:105:4
|
105 | fn hash_map_to_ordered_vec<K: Copy + Ord, V>(map: HashMap<K, V>) -> Vec<(K, V)> {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
returning the result of a `let` binding from a block:
core/runtime/src/connection.rs#L89
warning: returning the result of a `let` binding from a block
--> core/runtime/src/connection.rs:89:9
|
87 | let conn = Arc::new(conn);
| -------------------------- unnecessary `let` binding
88 |
89 | conn
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
87 ~
88 |
89 ~ Arc::new(conn)
|
|
usage of `contains_key` followed by `insert` on a `HashMap`:
core/runtime/src/connection.rs#L100
warning: usage of `contains_key` followed by `insert` on a `HashMap`
--> core/runtime/src/connection.rs:100:13
|
100 | / if exports.contains_key(&id) {
101 | | // cap is already exported, so drop this reference
102 | | table.dec_ref(handle).unwrap();
103 | | } else {
... |
112 | | self.send_local_op(op);
113 | | }
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
= note: `#[warn(clippy::map_entry)]` on by default
help: try
|
100 ~ if let std::collections::hash_map::Entry::Vacant(e) = exports.entry(id) {
101 + // cap needs to be exported
102 + let cap = table.wrap_handle(handle).unwrap();
103 + let perms = cap.get_permissions().bits();
104 + let perms = hearth_schema::Permissions::from_bits_retain(perms);
105 + let op = LocalCapOperation::DeclareCap { id, perms };
106 + let revoked = false;
107 + let export = Export { cap, revoked };
108 + e.insert(export);
109 + self.send_local_op(op);
110 + } else {
111 + // cap is already exported, so drop this reference
112 + table.dec_ref(handle).unwrap();
113 + }
|
|
hearth-test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, Swatinem/rust-cache@v2.2.0, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
hearth-test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
hearth-test:
main/ctl/src/main.rs#L99
function `get_daemon` is never used
|
hearth-test:
main/ctl/src/main.rs#L105
function `hash_map_to_ordered_vec` is never used
|
hearth-test
`hearth-ctl` (bin "hearth-ctl" test) generated 2 warnings
|
hearth-build (ubuntu-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, Swatinem/rust-cache@v2.2.0, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
hearth-build (ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
hearth-build (ubuntu-latest):
main/ctl/src/main.rs#L99
function `get_daemon` is never used
|
hearth-build (ubuntu-latest):
main/ctl/src/main.rs#L105
function `hash_map_to_ordered_vec` is never used
|
hearth-build (ubuntu-latest)
`hearth-ctl` (bin "hearth-ctl") generated 2 warnings
|
hearth-build (macos-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, Swatinem/rust-cache@v2.2.0, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
hearth-build (macos-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
hearth-build (macos-latest):
main/ctl/src/main.rs#L99
function `get_daemon` is never used
|
hearth-build (macos-latest):
main/ctl/src/main.rs#L105
function `hash_map_to_ordered_vec` is never used
|
hearth-build (macos-latest)
`hearth-ctl` (bin "hearth-ctl" test) generated 2 warnings
|