Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hand count sometimes incorrect #26

Closed
deeredman1991 opened this issue Jun 19, 2014 · 10 comments
Closed

Hand count sometimes incorrect #26

deeredman1991 opened this issue Jun 19, 2014 · 10 comments
Labels

Comments

@deeredman1991
Copy link

Was playing Paladin, it wasn't detecting that I had the first Hammer of Wrath in my hand. (the second one worked fine) Bringing my card count down to -1 I cannot remember if I started with hammer of wrath or not but I don't think I did.

Will get more details.

@azeier
Copy link
Member

azeier commented Jun 19, 2014

I think it's a problem where draws are just ignored sometimes. I had that happen with the opponent once. No idea if it's the same problem on the player side but it very well might be. The weird thing is, reloading the deck fixes the counts. at least when it happens for the opponent. I would assume it will work the same here.
I will add a more detailed debug log when I have the time. That should help figuring out where the problem is.

@deeredman1991
Copy link
Author

hmm, I'm not sure how your program works, or how the log works but I am assuming when you load a new deck it re-reads the log.

Maybe you could try having it read the log (or at least the last like 6-10 lines of the log) every turn or so?

If all else fails you could have a "quick fix" option in the options that reloads the deck every turn or so lol I know this might make some weird graphical flickering but it could work as a temporary solution. :)

@azeier
Copy link
Member

azeier commented Jun 19, 2014

I think re-reading parts of a game is quite a good amount of effort. Too much, for something I'm not even sure works, probably.

Reloading the game on every draw might be an option. I will do this if more detailed debug logs don't help.

How often does the problem occur for you?

@deeredman1991
Copy link
Author

About every 1 in 3 games. :( Although the recent update seems to have helped

@azeier
Copy link
Member

azeier commented Jun 19, 2014

Random guess: if you increase the UpdateDelay in the config.xml from 100 to 1000, does that change anything?

@deeredman1991
Copy link
Author

Played 14 rounds that seemed to fix it. :)

@azeier
Copy link
Member

azeier commented Jun 19, 2014

Oh really? I didn't expect that to work. That gives me a pretty good idea where the problem is.
Do you notice the increased delay in any way?

@deeredman1991
Copy link
Author

Not really, It is still very playable. :)

I haven't had a chance to play after the 14 rounds I played earlier but I will definitely let you know if it happens again. :)

@azeier azeier added the bug label Jun 20, 2014
@azeier azeier changed the title Hand count still not fixed Hand count sometimes incorrect Jun 20, 2014
@azeier
Copy link
Member

azeier commented Jun 22, 2014

99% sure I just found the reason for this bug and for #31 and fixed it ! :D

@azeier
Copy link
Member

azeier commented Jun 22, 2014

This should be fixed with the latest release (v0.2.16)

@azeier azeier closed this as completed Jun 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants