Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate all types import and download correctly #41

Open
70 of 72 tasks
randyzwitch opened this issue Nov 3, 2018 · 1 comment
Open
70 of 72 tasks

Validate all types import and download correctly #41

randyzwitch opened this issue Nov 3, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@randyzwitch
Copy link
Contributor

randyzwitch commented Nov 3, 2018 •
edited
Loading

This matrix represents whether test has been written, not just whether the method known to actually work

Export: sql_execute

Import: load_table

  • TINYINT
  • SMALLINT
  • INTEGER
  • BIGINT
  • FLOAT
  • DOUBLE
  • DECIMAL (string)
  • DECIMAL (float)
  • DECIMAL (double)
  • DECIMAL (rational)
  • DecFP
  • Decimals.jl
  • TEXT
  • BOOLEAN
  • DATE
  • TIME
  • TIMESTAMP
  • POINT (WKT)
  • LINESTRING (WKT)
  • POLYGON (WKT)
  • MULTIPOLYGON (WKT)
  • POINT (GeoInterface)
  • LINESTRING (GeoInterface)
  • POLYGON (GeoInterface)
  • MULTIPOLYGON (GeoInterface)
  • POINT (LibGEOS)
  • LINESTRING (LibGEOS)
  • POLYGON (LibGEOS)
  • MULTIPOLYGON (LibGEOS)
  • ARRAY (tested with all major types)

Import: load_table_binary_columnar

  • TINYINT
  • SMALLINT
  • INTEGER
  • BIGINT
  • FLOAT
  • DOUBLE
  • TEXT
  • BOOLEAN
  • DATE
  • TIME
  • TIMESTAMP
  • DECIMAL (add kw argument for decimal precision/scale, require to be set/assert to not upload without proper value
  • POINT (WKT)
  • LINESTRING (WKT)
  • POLYGON (WKT)
  • MULTIPOLYGON (WKT)
  • POINT (GeoInterface)
  • LINESTRING (GeoInterface)
  • POLYGON (GeoInterface)
  • MULTIPOLYGON (GeoInterface)
  • POINT (LibGEOS)
  • LINESTRING (LibGEOS)
  • POLYGON (LibGEOS)
  • MULTIPOLYGON (LibGEOS)
  • ARRAY
@randyzwitch
Copy link
Contributor Author

Related #38

@randyzwitch randyzwitch added the enhancement New feature or request label Nov 3, 2018
@randyzwitch randyzwitch changed the title Make sure timestamps/all types imported correctly Validate all types import and download correctly Nov 20, 2018
This was referenced Nov 20, 2018
Closed
Merged
randyzwitch added a commit that referenced this issue Nov 30, 2018
@randyzwitch
Work towards #41
23a29a0
randyzwitch added a commit that referenced this issue Nov 30, 2018
@randyzwitch
More robust dataframe types (#49)
59731a4 
* More robust dataframe types

Instead of generically typing the columns, use exact types from Thrift 
struct

* Mark geo types as String

Put back prior behavior until WKT parsing figured out

* Work towards #41

* Validate return types for sql_execute
@randyzwitch randyzwitch mentioned this issue Jan 25, 2019
Merged
@randyzwitch randyzwitch mentioned this issue Sep 16, 2019
Merged
@randyzwitch randyzwitch mentioned this issue Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@randyzwitch