Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Relative Time Expressions To Be Used in Between Expression #4

Closed
mrblueblue opened this issue Jun 3, 2017 · 1 comment
Closed

Comments

@mrblueblue
Copy link
Contributor

mrblueblue commented Jun 3, 2017

declare type NowExpression = {|
  type: "now"
|}

declare type RelativeTimeExpression = {|
  type: "relative",
  interval: "minute" | "hour" |  "day" | "week" | "month" | "quarter" | "year",
  step: number
|}
@mrblueblue mrblueblue self-assigned this Jun 16, 2017
@mrblueblue mrblueblue changed the title Support Relative and Range Time Filter Transform Support Relative Time Expressions To Be Used in Between Expression Jun 16, 2017
@mrblueblue mrblueblue removed their assignment Jun 18, 2017
@mrblueblue mrblueblue added P2 and removed P1 labels Jun 18, 2017
@nytai
Copy link
Contributor

nytai commented Jun 20, 2017

This is an interesting question. Aside from providing a sensible api, there is the question of where the timestamps are generated. In immerse currently (due to mapd-core not supporting datediff functions) the timestamps are generated before the query is issued. It's likely that we would want to offload the relative computations to the backend, via datediff functions, however if there is a caching layer this might be an issue (as queries would be the same).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants