Fix for empty codes on newer nodejs versions #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcelenza
added a commit
that referenced
this pull request
Sep 15, 2012
Fix for empty codes on newer nodejs versions
|
Thanks for the work! :) Sorry it took me 2 months to merge it in. |
|
I had completely forgotten about this PR. I'm using a client-side approach now, but anyways: Thanks for taking the time to merge! |
|
I had the same problem described here. After I did checkout the newest code everything works well. Would you mind to release this as a new version in npm? Thanks for the nice package anyway! |
|
Sorry for the delay. I have published the update to NPM. |
|
Nice! Thank you!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed the encoder would sometimes emit exit before the data was read from stdin or stderr. This happens a lot on node 0.8.1. This also makes some tests fail.
This pr waits for all filehandles to close, which is TheRightThing[tm] and fixes the issue for me.
I also took the liberty to fix package.json and gitignore files.
cheers,
bkw