Improvements #1
Merged
Improvements #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 16, 2011 20:27
…. Also added tests for finalizers.
HLURLDataSource --------------- - added responseHeaderValueForKey: - urlRequest supports "requestIfModifiedSince" key in the context, which adds an If-Modified-Since request header. - urlRequest returns NSMutableURLRequest HLJSONDataSource ---------------- - urlRequest supports "requestIfModifiedSince" key in the context, which adds an If-Modified-Since request header. - don't make the fail branch run if no data was found, instead the then branch's result is nil as per HLURLDataSource. Check the responseStatusCode if necessary. HLDownloadDataSource -------------------- - urlRequest supports "requestIfModifiedSince" key in the context, which adds an If-Modified-Since request header. - fixed memory leak when a redirect occurs
JimRoepcke
added a commit
that referenced
this pull request
Jun 17, 2011
Improvements from JimRoepcke
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per commit messages