Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom export - missing data #181

Closed
essel-dev opened this issue Jun 17, 2022 · 4 comments
Closed

Custom export - missing data #181

essel-dev opened this issue Jun 17, 2022 · 4 comments
Assignees

Comments

@essel-dev
Copy link

Thanks for making Hebcal available!

I found some data missing when trying the following imports into Google Calendar, see attached screenshot:

  1. Zmanim for Candle lighting and Havdalah only highlighted in blue.
  2. Zmanim for all events highlighted in grey.

With export 1 the Havdalah times are missing for:

  1. motzei Rosh Hashana
  2. motzei Yom Kippur

This happens yearly.

Screenshot 2022-06-17 18 51 25

mjradwin added a commit that referenced this issue Jun 17, 2022
@mjradwin mjradwin self-assigned this Jun 17, 2022
mjradwin added a commit that referenced this issue Jun 17, 2022
when options.candlelighting==true and options.noHolidays==true
(#181)
mjradwin added a commit to hebcal/hebcal-web that referenced this issue Jun 17, 2022
 when options.candlelighting==true and options.noHolidays==true
 hebcal/hebcal-es6#181
@mjradwin
Copy link
Member

Thanks for the bug report! We have fixed the issue for the missing Havdalah times on motzei Rosh Hashana and Yom Kippur.

Google Calendar may take up to 7 days to refresh iCalendar feeds

@essel-dev
Copy link
Author

Awesome, thanks so much!

I think fasting times for Tish'a B'Av shouldn't show up in export Candle lighting and Havdalah only, Tish'a B'Av is a minor fast.

@mjradwin
Copy link
Member

Glad we were able to fix the problem.

Tish'a B'Av is certainly a public fast day, but I am not sure it's considered a "minor" fast. Like Yom Kippur, it's 25 hours long, so I believe it qualifies as a major fast.

@essel-dev
Copy link
Author

True, but with the settings below, shouldn't only candle lighting and havdalah times show up?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants