Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Candlelighting Missing For 2nd Day of Pesach Outside of Israel #94

Closed
sabonmichal opened this issue Nov 18, 2014 · 6 comments
Closed

Candlelighting Missing For 2nd Day of Pesach Outside of Israel #94

sabonmichal opened this issue Nov 18, 2014 · 6 comments

Comments

@sabonmichal
Copy link

http://www.hebcal.com/hebcal/?year=2015&month=4&yt=G&v=1&nh=on&i=off&lg=s&vis=on&c=on&geo=zip&zip=90210&b=18&m=72&.cgifields=nx&.cgifields=nh&.cgifields=mf&.cgifields=ss&.s=Create+Calendar

Aren't candles lit for the 2nd day? This calendar, for example, lists a candlelighting for the 2nd day:

http://www.chabad.org/calendar/candlelighting_cdo/aid/6226/jewish/Candle-Lighting-Times.htm#locationId=90210&locationType=2&tdate=4/1/2015
@mjradwin mjradwin mentioned this issue Nov 18, 2014
Closed
@sabonmichal
Copy link
Author

we are using the api to close our online store over Shabbat & Holidays. It is detecting a holiday by candlelighting time so since there is a havdalah time listed for the end of the first day of Pesach but no candlelighting, the system will not know to close the shop for the second day and will thus remain open. How difficult would it be to implement the 2nd day candlelighting into your api and what is the eta? Is there a reason is was not included to begin with? Thank you!

@mjradwin
Copy link
Member

This has been an open feature request for 13+ years (see issue #12).

We would welcome a pull request that implement this. If it is important to your online store, would you consider working on that? Many others would benefit.

@sabonmichal
Copy link
Author

we don't have any in-house developers but I will mention it to the store owner

@Scimonster
Copy link
Contributor

Not an answer to your question, but as it says here, you shouldn't really
need to close the store on Shabbat:
http://judaism.stackexchange.com/q/2671/5151

On Wednesday, November 19, 2014, sabonmichal notifications@github.com
wrote:

we are using the api to close our online store over Shabbat & Holidays. It
is detecting a holiday by candlelighting time so since there is a havdalah
time listed for the end of the first day of Pesach but no candlelighting,
the system will not know to close the shop for the second day and will thus
remain open. How difficult would it be to implement the 2nd day
candlelighting into your api and what is the eta?

—
Reply to this email directly or view it on GitHub
#94 (comment).

Sent from Gmail Mobile

aperomsik added a commit to aperomsik/hebcal that referenced this issue Nov 15, 2015
@aperomsik
Basic Zemanim support.
cb1c95e 
Changed Candlelighting to say Light Candles Before or Light Candles
After. Added candle lighting on the second night of Yom Tov, fixing
issue hebcal#94.

When -Z is included on the command line, a basic set of
Zemanim is included for each day, namely:

(ZMAN_SUNRISE | ZMAN_SZKS | ZMAN_TEFILAH |
 ZMAN_CHATZOT |
 ZMAN_MINCHA_GEDOLA | ZMAN_MINCHA_KETANA |
 ZMAN_PLAG_HAMINCHA | ZMAN_SUNSET | ZMAN_TZAIT_42)

iso8859-8 text is not included for these but should be added. (Or maybe
it's time to switch to UTF-8?)
@mjradwin
Copy link
Member

mjradwin commented Dec 2, 2015

After many many years, this is fixed in hebcal-4.1. Thanks @aperomsik!

@mjradwin mjradwin closed this as completed Dec 2, 2015
@sabonmichal
Copy link
Author

thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Scimonster @mjradwin @sabonmichal