New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Israel DST ending date #80

Merged
merged 2 commits into from Oct 10, 2013

Conversation

Projects
None yet
2 participants
@yisraeldov
Contributor

yisraeldov commented Oct 10, 2013

The israeli DST scheme wasn't right for this year, here is a fix, for the DST end. we have a while till the DST start, so I'll leave that for now

http://en.wikipedia.org/wiki/Israel_Summer_Time#2013.E2.80.93Present

@yisraeldov

This comment has been minimized.

Show comment
Hide comment
@yisraeldov

yisraeldov Oct 10, 2013

Contributor

The second commit is a different issue, sunrise and sunset times weren't using DST in the calculations

Contributor

yisraeldov commented Oct 10, 2013

The second commit is a different issue, sunrise and sunset times weren't using DST in the calculations

mjradwin added a commit that referenced this pull request Oct 10, 2013

Merge pull request #80 from yisraeldov/master
Fixing Israel DST ending date
Thanks Yisrael Dov!

@mjradwin mjradwin merged commit 14bc630 into hebcal:master Oct 10, 2013

1 check passed

default The Travis CI build passed
Details
@mjradwin

This comment has been minimized.

Show comment
Hide comment
@mjradwin

mjradwin Oct 10, 2013

Member

Thanks for the patches. They look great!

-michael

On Thu, Oct 10, 2013 at 11:06 AM, Yisrael Dov Lebow <
notifications@github.com> wrote:

The second commit is a different issue, sunrise and sunset times weren't
using DST in the calculations


Reply to this email directly or view it on GitHubhttps://github.com//pull/80#issuecomment-26076821
.

Member

mjradwin commented Oct 10, 2013

Thanks for the patches. They look great!

-michael

On Thu, Oct 10, 2013 at 11:06 AM, Yisrael Dov Lebow <
notifications@github.com> wrote:

The second commit is a different issue, sunrise and sunset times weren't
using DST in the calculations


Reply to this email directly or view it on GitHubhttps://github.com//pull/80#issuecomment-26076821
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment