Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Composer 2 support #25

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Add Composer 2 support #25

merged 1 commit into from
Nov 18, 2020

Conversation

ossobuffo
Copy link
Contributor

Composer 2's PluginInterface has added two new methods. Adding stubs for these allows us to be compatible with composer-plugin-api ^2.0.

@mbaynton
Copy link

mbaynton commented Oct 6, 2020

Possible fix for #23

@scotself
Copy link

Yes please 👍 One of the Drupal plugins keeping us from using composer 2.

Copy link

@pefferen pefferen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do do the trick.

@pinoniq
Copy link

pinoniq commented Nov 4, 2020

Any idea on when this will be merged? This currently makes using drupal/console projects unusable with composer 2. Given that dev-tools like e.g. lando moved to composer2, this is rather a blocker. Is there anything I can do to get this merged?

@bob-hinrichs
Copy link

This is now blocking our projects, as Lando is also now on Composer 2 in its most recent release.

@mukeshsah08
Copy link

mukeshsah08 commented Nov 11, 2020

Could you please merge this MR ASAP. It's required for my current project.
Thanks!

@bob-hinrichs
Copy link

bob-hinrichs commented Nov 11, 2020

@pefferen and @trackleft - er, very sorry if I tagged the wrong people here. Who can merge this? My builds are no longer working on Pantheon because this is not merged yet.
- drupal/console-extend-plugin[0.1.0, ..., 0.9.4] require composer-plugin-api ^1.0 -> found composer-plugin-api[2.0.0] but it does not match the constraint.

@mbaynton
Copy link

We know this is causing compatibility issues with Pantheon's integrated composer build process. I reached out to @jmolivas, one of the original maintainers for Drupal Console, and it's on his radar. ETA by this weekend for a tagged release.

Copy link
Member

@jmolivas jmolivas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmolivas
Copy link
Member

Tagging a new release this week

@jmolivas jmolivas merged commit eff6da9 into hechoendrupal:master Nov 18, 2020
@jmolivas
Copy link
Member

@ossobuffo Thanks for your contribution, your PR was merged. This will be included in the next release.

@esolitos
Copy link

@jmolivas That's great to hear!
Do you have any idea when you'll tagging a release? :)

@alex-belyaev
Copy link

@jmolivas hi, is there any updates on new tag?

@xtfer
Copy link

xtfer commented Nov 25, 2020

Thats great @jmolivas, but this is now blocking drupal-console, which in turn is causing blockers on just about every build system running Drupal on the planet. :) Can we get a release?

@driskell
Copy link

If it helps - switching to use composer v1 makes this a minor problem. I’m not aware of anything that requires composer v2 just yet that would ever make this a blocker.

There’s several options available.
https://getcomposer.org/download/
Latest installer can be given --1 argument to download only v1. To fix any self updating build scripts the same argument can be appended to selfupdate.
Also for GitHub Actions there’s several actions available that can set up the right PHP and Composer versions as needed.

Composer v2 is quite new still so I can guess the testing and confidence in releasing an update can in some cases take some time.

@BrianGilbert
Copy link

@driskell Composer 1 is deprecated now, and Composer 2 is way faster.. ideally this can get fixed soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet