Merge pull request #1337 from jmolivas/fix-code-warnings-insight-82

[console] Fix code warnings insight 82
hechoendrupal · Nov 24, 2015 · 06f0dba · 06f0dba
2 parents bd84992 + b301af4
commit 06f0dba
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 12 deletions.
diff --git a/src/Command/Views/DebugCommand.php b/src/Command/Views/DebugCommand.php
@@ -171,10 +171,10 @@ protected function getAllViews($tag, $status, $output, $table)
      * Gets a list of paths assigned to the view.
      *
      * @param \Drupal\views\Entity\View $view
-     *                                        The view entity.
+     *      The view entity.
      *
      * @return array
-     *               An array of paths for this view.
+     *      An array of paths for this view.
      */
     protected function getDisplayPaths(View $view, $display_id = null)
     {
@@ -185,8 +185,8 @@ protected function getDisplayPaths(View $view, $display_id = null)
             if ($display->hasPath()) {
                 $path = $display->getPath();
                 if (strpos($path, '%') === false) {
-                    // @todo Views should expect and store a leading /. See:
-                    //   https://www.drupal.org/node/2423913
+                    //  @see Views should expect and store a leading /. See:
+                    //  https://www.drupal.org/node/2423913
                     $all_paths[] = '/'.$path;
                 } else {
                     $all_paths[] = '/'.$path;

diff --git a/src/Helper/DrupalHelper.php b/src/Helper/DrupalHelper.php
@@ -182,7 +182,6 @@ public function setMinimalContainerPreKernel()
         // Create a minimal mocked container to support calls to t() in the pre-kernel
         // base system verification code paths below. The strings are not actually
         // used or output for these calls.
-        // @todo Separate API level checks from UI-facing error messages.
         $container = new ContainerBuilder();
         $container->setParameter('language.default_values', Language::$defaultValues);
         $container

diff --git a/src/Helper/KernelHelper.php b/src/Helper/KernelHelper.php
@@ -104,7 +104,6 @@ public function bootKernel()
     public function getKernel()
     {
         // Add support for Acquia Dev Desktop sites on Mac OS X
-        // @TODO: Check if this condition works in Windows
         $devdesktop_dir = getenv('HOME') . "/.acquia/DevDesktop/DrupalSettings";
         if (file_exists($devdesktop_dir)) {
             $_SERVER['DEVDESKTOP_DRUPAL_SETTINGS_DIR'] = $devdesktop_dir;

diff --git a/src/Helper/SiteHelper.php b/src/Helper/SiteHelper.php
@@ -49,7 +49,7 @@ public function setSiteRoot($siteRoot)
     private function discoverModules()
     {
         /*
-         * @todo Remove DrupalExtensionDiscovery subclass once
+         * @see Remove DrupalExtensionDiscovery subclass once
          * https://www.drupal.org/node/2503927 is fixed.
          */
         $discovery = new DrupalExtensionDiscovery(\Drupal::root());

diff --git a/templates/gitbook/available-commands-list.md.twig b/templates/gitbook/available-commands-list.md.twig
@@ -4,7 +4,7 @@
 {% endif %}
 {% if last_namespace is defined %}
 
-  {# @TODO fix empty new line hack #}
+  {# Empty new line hack #}
 {% endif %}
 {% spaceless %}
 {% for command in commands %}

diff --git a/templates/module/src/Plugin/Field/FieldFormatter/fieldformatter.php.twig b/templates/module/src/Plugin/Field/FieldFormatter/fieldformatter.php.twig
@@ -28,7 +28,7 @@ use Drupal\Core\Form\FormStateInterface;
  *   }
 {% else %}
 
- *   @todo: At least one field_types annotation array entry is necessary to display this formatter in the UI.
+ *   At least one field_types annotation array entry is necessary to display this formatter in the UI.
  *   ex. field_types = { "field_type" }
 {% endif %}
  * )

diff --git a/templates/module/src/Plugin/Field/FieldType/fieldtype.php.twig b/templates/module/src/Plugin/Field/FieldType/fieldtype.php.twig
@@ -32,14 +32,14 @@ use Drupal\Core\TypedData\DataDefinition;
 {% endif %}
 {% else %}
 
- *   @todo: Create and/or assign a default_widget.
+ *   Create and/or assign a default_widget.
  *   ex. default_widget = "field_widget"
 {% endif %}
 {%  if default_formatter %}
  *   default_formatter = "{{ default_formatter }}"
 {% else %}
 
- *   @todo: Create and/or assign a default_formatter.
+ *   Create and/or assign a default_formatter.
  *   ex. default_formatter = "field_formatter"
 {%  endif %}
  * )

diff --git a/templates/module/src/Plugin/Field/FieldWidget/fieldwidget.php.twig b/templates/module/src/Plugin/Field/FieldWidget/fieldwidget.php.twig
@@ -26,7 +26,7 @@ use Drupal\Core\Form\FormStateInterface;
  *   }
 {% else %}
 
- *   @todo: At least one field_types annotation array entry is necessary to display this formatter in the UI.
+ *   At least one field_types annotation array entry is necessary to display this formatter in the UI.
  *   ex. field_types = { "field_type" }
 {% endif %}
  * )