Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generate content-entity command #147

Closed
vacho opened this issue Jul 9, 2014 · 6 comments
Closed

Add generate content-entity command #147

vacho opened this issue Jul 9, 2014 · 6 comments

Comments

@vacho
Copy link
Contributor

vacho commented Jul 9, 2014

This is a issue for requirement of a new feature

This feature complement the 'generate entity' recently added by @jmolivas at Merge pull request #142 which generate 'configuration-entity'

@jmolivas
Copy link
Member

jmolivas commented Jul 9, 2014

This sounds great we may use this as a reference https://www.drupal.org/node/2192175

Do you see this new functionality as:

  • Same command generate:entity and ask for entity type then take decisions based on this value
  • Two separated commands generate:entity:configuration and generate:entity:content

@dmouse
Copy link
Member

dmouse commented Jul 9, 2014

I think that we should separate the entity commands and avoid have much logic in a single command

dmouse@d78054f#diff-c97f8aef2ef2c416fe80463ddd823dd3L31

@jmolivas
Copy link
Member

jmolivas commented Jul 9, 2014

I like the idea of separate them, since we will avoid having logic in one single command and within template files

@vacho
Copy link
Contributor Author

vacho commented Jul 9, 2014

Yes I agree that maintain the code as simple as possible.

At the time I was programmed using the same command and adding logic to discern at EntityGenerator.php

But I can do to separate the commands. Let's see when I apply Pull Request

@jmolivas
Copy link
Member

jmolivas commented Jul 9, 2014

@vacho be aware class name changed take a look at #150

src/Command/GeneratorEntityCommand.php → src/Command/GeneratorEntityConfigCommand.php
src/Generator/EntityGenerator.php → src/Generator/EntityConfigGenerator.php

@vacho
Copy link
Contributor Author

vacho commented Jul 10, 2014

very good decision and action.

Right now in my branch "content-entities" can be created. Now it

  1. Update my branch there and make it work.
  2. Perform a battery of tests.
  3. Perform pull request.

I go for that.

g3r4 pushed a commit to g3r4/drupal-console that referenced this issue Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants