Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[module:install] [feature-request] auto-install module's dependencies #1580

Closed
vincenzodibiaggio opened this issue Dec 26, 2015 · 9 comments
Closed

Comments

@vincenzodibiaggio
Copy link

No description provided.

@vincenzodibiaggio
Copy link
Author

I can work on this if other people need it

jmolivas added a commit to jmolivas/drupal-console that referenced this issue Dec 28, 2015
@jmolivas
Copy link
Member

@vincenzodibiaggio: Thanks for reporting and proposed to have it fixed, sorry but fixing an issue I found:

Recoverable fatal error: Argument 1 passed to Drupal\Core\ProxyClass\Extension\ModuleInstaller::install() must be of the type array, null given, called in /Users/jmolivas/develop/drupal/modules/console/src/Command/Module/InstallCommand.php on line 134 and defined in Drupal\Core\ProxyClass\Extension\ModuleInstaller->install() (line 85 of /Users/jmolivas/develop/drupal/sites/drupal.dev/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php).

I realize about this as well and fixed on this PR #1592.

@vincenzodibiaggio
Copy link
Author

👍

@LightGuard
Copy link

I'd love to see this too, or at the very least an option to pass to have dependencies installed

@jmolivas
Copy link
Member

jmolivas commented Jan 4, 2016

This is fixed now. if you try to install modules with dependencies it asks you to install those.

What is missing is a way to download the missing dependencies, is this what you are asking for @LightGuard @vincenzodibiaggio?

@LightGuard
Copy link

Partly. If the modules are already downloaded you don't need to download them again, obviously simply install them.

My use case is doing this in essentially a headless install, it is actually a docker setup where drupal console runs as part of starting up or building the container. I don't have the option of answering questions. IMO any question you're asked on the console should have a flag you can specify when you run the command if you are running without interaction capabilities.

@jmolivas
Copy link
Member

jmolivas commented Jan 4, 2016

@LightGuard: You can easily create a yml file including any command plus options & arguments

And use the chain command to call that file definition.

More information about this feature:

If you are not sure about what option to use on the chain definition you can execute a command and pass the --generate-chain option.
drupal-console-generate-chain

@jmolivas
Copy link
Member

jmolivas commented Jan 4, 2016

@LightGuard I will take a look at the download module dependencies when installing modules, since I think will be a useful feature to have.

@LightGuard
Copy link

Fair enough. I have an issue that's somewhat related to this:

drupal module:install hal rest serialization

asks to install dependencies, but you are installing them in the same go. This used to work in 0.9.9 but changed sometime between that and current.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants