Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[console] Setup CodeSniffer check generated code on project build #200

Closed
jmolivas opened this issue Sep 14, 2014 · 4 comments
Closed

[console] Setup CodeSniffer check generated code on project build #200

jmolivas opened this issue Sep 14, 2014 · 4 comments
Assignees
Milestone

Comments

@jmolivas
Copy link
Member

Setup CodeSniffer check generated code on project build

@jmolivas jmolivas added this to the v0.3.0 milestone Sep 14, 2014
@cosmicdreams
Copy link
Contributor

As in bring in the dependencies of PHP_CodeSniffer and then.... what? Provide documentation on how to use it?

@jmolivas
Copy link
Member Author

The idea is to use PHP_CodeSniffer on project build to make sure the generated code complains Drupal coding standards, am I right @dmouse ?

@dmouse
Copy link
Member

dmouse commented Sep 16, 2014

Is right, the codesniffer is the way to check that the generated code is compliance to Drupal 8 Standard.

for try this test only run

$ ./bin/phpunit
$ ./bin/phpcs --standard=vendor/drupal/coder/coder_sniffer/Drupal/ruleset.xml /tmp/modules/*

@jmolivas jmolivas changed the title Setup CodeSniffer check generated code on project build [general] Setup CodeSniffer check generated code on project build Feb 15, 2015
@jmolivas jmolivas changed the title [general] Setup CodeSniffer check generated code on project build [console] Setup CodeSniffer check generated code on project build Feb 22, 2015
@jmolivas
Copy link
Member Author

Ia m closing this since travis was updated.
I am opening an issue on the documentation project to "Add instruction how to setup and use CodeSniffer" hechoendrupal/drupal-console-book#56

g3r4 pushed a commit to g3r4/drupal-console that referenced this issue Jul 19, 2017
* Replacing in translation keys from _ to -

* Adding translation messages for the commands:
chain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants