Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[generate:plugin:ckeditorbutton] Missing method visibility for generated CKEditor Plugin #2150

Closed
dabito opened this issue Apr 20, 2016 · 0 comments

Comments

@dabito
Copy link
Contributor

dabito commented Apr 20, 2016

Problem/motivation

Public visibility is missing in generated ckeditor plugin methods:

Solution

Add public visibility to the following methods in the ckeditor plugin template:

  /**
   * {@inheritdoc}
   */
  function isInternal() {
    return FALSE;
  }

  /**
   * {@inheritdoc}
   */
  function getDependencies(Editor $editor) {
    return array();
  }

  /**
   * {@inheritdoc}
   */
  function getLibraries(Editor $editor) {
    return array();
  }
dabito pushed a commit to dabito/DrupalConsole that referenced this issue Apr 20, 2016
Adds missing visibility for generated ckeditorbutton methods
@dabito dabito changed the title [generate:plugin:ckeditorbutton] Missing visibility for generated CKEditor Plugin methods [generate:plugin:ckeditorbutton] Missing method visibility for generated CKEditor Plugin Apr 20, 2016
jmolivas pushed a commit that referenced this issue Apr 26, 2016
Missing visibility ckeditorbutton methods, Fixes: #2150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants