Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the core version validation in generate:module #1588

Merged
merged 2 commits into from Dec 30, 2015

Conversation

tstoeckler
Copy link
Contributor

Currently when running generate:module you get a called to undefined function 8.x because there is an incorrect parameter that is being passed to the Symfony question helper. I implemented some basic validation of the core property.

@jmolivas jmolivas modified the milestone: 0.10.1 Dec 28, 2015
@jmolivas jmolivas modified the milestone: 0.10.1 Dec 28, 2015
@jmolivas
Copy link
Member

@tstoeckler: Thanks and 👍 for the PR.

Since Drupal Console only supports Drupal 8 and up, this validation should only accept numbers equal and greater than 8.

dc-validate-core-version

@jmolivas jmolivas modified the milestones: nice-to-have, 0.10.1 Dec 29, 2015
@tstoeckler
Copy link
Contributor Author

There you go:

core-version-validate

@jmolivas
Copy link
Member

Awesome great JIT for the release

jmolivas added a commit that referenced this pull request Dec 30, 2015
Fix the core version validation in generate:module
@jmolivas jmolivas merged commit dddfaa7 into hechoendrupal:master Dec 30, 2015
@jmolivas jmolivas modified the milestones: 0.10.1, nice-to-have Dec 30, 2015
@vincenzodibiaggio
Copy link

Enter Drupal Core version [8.x]:
 > 8
PHP Fatal error:  Call to undefined function 8.x() in [...]vendor/symfony/console/Helper/SymfonyQuestionHelper.php on line 36
PHP Stack trace:

I not understand, what is the correct value?

@jmolivas
Copy link
Member

jmolivas commented Jan 2, 2016

@vincenzodibiaggio: 8.x is the correct value, I will try using 8 and add comments if found anything.

@tstoeckler tstoeckler deleted the fix-generate-module branch January 2, 2016 18:27
@tstoeckler
Copy link
Contributor Author

@vincenzodibiaggio Please update to the latest master, that error should no longer appear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants