Use ContentEntityDeleteForm as a base class for content entity delete forms #1589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ContentEntityConfirmFormBase
is being used butContentEntityDeleteForm
already provides the delete-specific information.It is in fact superior to the current delete template because it properly handles entity translations.
I don't know if there is much of a use-case of overriding the delete form (i.e. I usually just reference
ContentEntityDeleteForm
in the entity annotation directly), but I went for the minimally invasive change for now.