Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[help] Make command translatable and a little zh_hans translation update. #1791

Merged
merged 13 commits into from
Jan 26, 2016

Conversation

ranqiangjun
Copy link
Contributor

I create an issue here ( [Translation] Make help command translatable #1790).

Please review this PR, Thanks!

@jmolivas jmolivas changed the title Make help command translatable and a little zh_hans translation update [help] Make command translatable and a little zh_hans translation update. Jan 26, 2016
@jmolivas jmolivas modified the milestone: 0.10.6 Jan 26, 2016
@jmolivas
Copy link
Member

@ranqiangjun: Thanks for the PR 👍 on this feature.
I tested and found a different output when running the drupal --help

  • Original:
    drupal-help-original
  • Updated:
    drupal-help-updated

@jmolivas jmolivas modified the milestones: 0.10.7, 0.10.6 Jan 26, 2016
@ranqiangjun
Copy link
Contributor Author

I noticed that. But I don't know how to fix it right now. I'll try to fix it later. Any suggestions on how to fix it? Thanks!

@ranqiangjun
Copy link
Contributor Author

Fixed @jmolivas Thanks!

fixed

@ranqiangjun
Copy link
Contributor Author

@enzolutions Conflicts resolved, Thanks!

@enzolutions
Copy link
Contributor

testing

@enzolutions enzolutions modified the milestones: 0.10.6, 0.10.7 Jan 26, 2016
@jmolivas
Copy link
Member

Looks great, thanks for fixing it.

jmolivas added a commit that referenced this pull request Jan 26, 2016
[help] Make command translatable and a little zh_hans translation update.
@jmolivas jmolivas merged commit 526d2b1 into hechoendrupal:master Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants