Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[module:download] path option #2124

Merged
merged 9 commits into from
Apr 28, 2016
Merged

[module:download] path option #2124

merged 9 commits into from
Apr 28, 2016

Conversation

Saphyel
Copy link
Contributor

@Saphyel Saphyel commented Apr 11, 2016

For more info #2065

This is the first pull request for allow more options when you download a module

Current status

  • Select the path

@Saphyel
Copy link
Contributor Author

Saphyel commented Apr 16, 2016

@darol100 I was thinking that maybe we can split this PR into 2, so this can be merge and we deal later with latest & version/release option

@itsdarrylnorris
Copy link
Contributor

@Saphyel , I think that sounds like a great idea.

@Saphyel Saphyel changed the title [module:download] more options [module:download] path option Apr 18, 2016
@Saphyel
Copy link
Contributor Author

Saphyel commented Apr 18, 2016

@darol100 ready to test/merge

@jmolivas
Copy link
Member

@Saphyel Thanks for your contribution! We'll take a look at it as soon as possible!

@jmolivas jmolivas modified the milestones: 1.0.0-alpha1, 1.0.0-beta1 Apr 18, 2016
@@ -3,6 +3,9 @@ arguments:
module: 'Module or modules to be enabled should be separated by a space'
options:
latest: 'Default to download most recent version'
module-path: 'The path of the contrib project'
Copy link
Contributor

@itsdarrylnorris itsdarrylnorris Apr 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change all module-path to just path ? We already are inside of the module it seem redundant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darol100 in fact I thought when I started to use the same rather than duplicate... because you/we ask for the same thing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saphyel , That is minor improvement that we recently started to do whenever we do new enhancement, which is cleaning the redundancy between names.

Hopefully for the stable release we could have all command with clean names.

@jmolivas jmolivas modified the milestones: 1.0.0-alpha1, 1.0.0-alpha2 Apr 21, 2016
@jmolivas jmolivas merged commit 13d6d51 into hechoendrupal:master Apr 28, 2016
@Saphyel Saphyel deleted the download branch June 2, 2016 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants