-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[module:download] path option #2124
Conversation
@darol100 I was thinking that maybe we can split this PR into 2, so this can be merge and we deal later with |
@Saphyel , I think that sounds like a great idea. |
@darol100 ready to test/merge |
@Saphyel Thanks for your contribution! We'll take a look at it as soon as possible! |
@@ -3,6 +3,9 @@ arguments: | |||
module: 'Module or modules to be enabled should be separated by a space' | |||
options: | |||
latest: 'Default to download most recent version' | |||
module-path: 'The path of the contrib project' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change all module-path
to just path
? We already are inside of the module it seem redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@darol100 in fact I thought when I started to use the same rather than duplicate... because you/we ask for the same thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Saphyel , That is minor improvement that we recently started to do whenever we do new enhancement, which is cleaning the redundancy between names.
Hopefully for the stable release we could have all command with clean names.
For more info #2065
This is the first pull request for allow more options when you download a module
Current status