Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2389 Feature Request: Devel dumper change command #2390

Merged
merged 4 commits into from Jul 14, 2016

Conversation

twhiston
Copy link
Contributor

@twhiston twhiston commented Jun 2, 2016

No description provided.

@jmolivas jmolivas modified the milestone: 1.0.0-beta3 Jun 2, 2016
@jmolivas
Copy link
Member

jmolivas commented Jun 4, 2016

@twhiston Since the command is within DC core namespace Drupal\px_debug_tools\Command; must be Drupal\Console\Command;

@twhiston
Copy link
Contributor Author

twhiston commented Jun 6, 2016

you are completely correct! This is legacy from developing it in a custom module and then moving it into the drupal console command, please accept both my apologies and the updated version of the code ;)

@twhiston
Copy link
Contributor Author

can this now be accepted and merged?

@jmolivas
Copy link
Member

@twhiston may you sync this PR with the latest changes on master to fix the error PHP Fatal error: Trait 'Drupal\Console\Command\ModuleTrait' not found in

@twhiston
Copy link
Contributor Author

done

@jmolivas jmolivas merged commit 2918123 into hechoendrupal:master Jul 14, 2016
@jmolivas
Copy link
Member

@twhiston PR was merged. This will be included on next release, Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants