Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exec] Add new command #2444

Merged
merged 7 commits into from Jun 26, 2016
Merged

[exec] Add new command #2444

merged 7 commits into from Jun 26, 2016

Conversation

Saphyel
Copy link
Contributor

@Saphyel Saphyel commented Jun 23, 2016

Implementation of #1907 part 1

This command execute an external command, the idea is provide similar functionality to phing

Example of usage:

drupal exec "ls -al"

@Saphyel
Copy link
Contributor Author

Saphyel commented Jun 23, 2016

@enzolutions recommended follow this approach

@novia713
Copy link
Contributor

novia713 commented Jun 24, 2016

@Saphyel i see you're using Symfony\Component\Process\Process;
perhaps you ought use the already existent /src/Utils/ShellProcess.php

it in fact also uses Process() but it also shows a percent advance graphic ....
it was developed for showing advance in composer calls, but should be usable also in any command
i'm not sure, perhaps ShellProcess is not ideal for you, but i thinked you should know it ....

@novia713
Copy link
Contributor

i was being thinking about this.
i suggest you @Saphyel to use the existing ShellProcess, to avoid duplication
perhaps you should refactor or add more options (to not show the progress bar) to ShellProcess
i did that, ping me anytime if you want talk about this

@Saphyel
Copy link
Contributor Author

Saphyel commented Jun 25, 2016

@novia713 I'll try to do it later today, I really appreciate your comments! ^^ I'm learning more than I thought with this PR!

@Saphyel
Copy link
Contributor Author

Saphyel commented Jun 25, 2016

@novia713 take a look now! 💃

@Saphyel
Copy link
Contributor Author

Saphyel commented Jun 25, 2016

By the way I fixed the output of --composer:
screenshot_20160625_143712

@novia713
Copy link
Contributor

yes, i was aware of that lack of linebreak in between the progress bar & the info message.
i lived very sad these late days because of it, now i'm happy !! 👯

@novia713
Copy link
Contributor

reminder for @novia713 (myself) to open an issue to change «shellexec_output» key name in config.yml in favour of «composer_output» when this PR were merged

@jmolivas jmolivas merged commit 85e3070 into hechoendrupal:master Jun 26, 2016
@jmolivas
Copy link
Member

@Saphyel PR was merged. This will be included on next release, Thanks.

@novia713 Thanks for helping to test and commenting.

@jmolivas jmolivas modified the milestones: 1.0.0-beta4, 1.0.0-beta3 Jun 26, 2016
@jmolivas jmolivas changed the title Add Exec command [exec] Add new command Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants