Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved instructions at method title prompt #2490

Merged

Conversation

wranvaud
Copy link
Contributor

@wranvaud wranvaud commented Jul 3, 2016

as documented on issue #2025

@enzolutions enzolutions added this to the 1.0.0-beta4 milestone Jul 3, 2016
@enzolutions
Copy link
Contributor

Hi @wranvaud Thanks for your contribution.

But you can do an extra work, of replacing the string in all other languages.

You can do this with Drupal Console YAML commands in DrupalConsole language folder config/translations

In each language folder, you can run this

$ drupal yaml:update:value ./generate.controller.yml questions.title "Enter the Controller method title (to stop adding more methods, leave this empty)"

and

drupal yaml:update:value ./generate.controller.yml messages.title-empty "Title must contain a value (you must enter at least one method)"

After apply in all language commit the new changes and PR will be updated.

@enzolutions
Copy link
Contributor

Thanks @wranvaud for the change, but we don't allow partial lines translated, because the tool we use to report pending translation don't understand that 'yet'. please put the whole line in English.

@enzolutions
Copy link
Contributor

@wranvaud Actually Catalan, Hindi, Indonesian, Vietanesse and Chinese Simplified still incorrect, please double check

@enzolutions
Copy link
Contributor

Perfect. I am going to merge, thanks for your commitment with this PR @wranvaud , welcome as contributor to Drupal Console project.

@wranvaud
Copy link
Contributor Author

wranvaud commented Jul 3, 2016

Thank you for your guidance @enzolutions !

@enzolutions enzolutions merged commit b30ce94 into hechoendrupal:master Jul 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants