New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functionality from $node entity to make generated entities revisionable #2536
Conversation
@pdscti Do you mind to sync changes to properly test this PR. |
@@ -38,6 +38,13 @@ protected function configure() | |||
InputOption::VALUE_NONE, | |||
$this->trans('commands.generate.entity.content.options.is-translatable') | |||
); | |||
|
|||
$this->addOption( | |||
'is-revisionable', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update this option as revisionable
instead.
We are planning to update is-translatable
as translatable
only as well.
Hi @jmolivas Rebased and amended the name of the option. Cheers for the feedback :) |
@pdscti there is still an issue with PHPUnit on the build https://travis-ci.org/hechoendrupal/DrupalConsole/jobs/149409889#L280
|
Hi @jmolivas - thought I'd caught all of the changes in the tests, but looks like I missed a couple. Just trying again. |
@jmolivas Tests are passing: let me know if I've missed something though: PHP Unit is new to me. |
@pdscti looking at this early next week. |
@pdscti sorry for the late reply, but tagging the RC took longer that expected do you mind to sync your PR to have it merged. EN translations got moved to this repo => https://github.com/hechoendrupal/drupal-console-en The rest of the languages will be moved soon. |
@jmolivas I'm doing git merge upstream/master but it's telling me there are no changes to merge in. Am I missing something? |
@jmolivas That got it: I'd lost my remote origin somehow in all the excitement. |
@pdscti looking at this today thanks for making the sync |
@pdscti Thanks for your contribution, your PR was merged. This will be included on the next release. |
No description provided.