Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality from $node entity to make generated entities revisionable #2536

Merged
merged 15 commits into from Oct 14, 2016

Conversation

MrDaleSmith
Copy link
Contributor

No description provided.

@jmolivas
Copy link
Member

jmolivas commented Aug 2, 2016

@pdscti Do you mind to sync changes to properly test this PR.

@@ -38,6 +38,13 @@ protected function configure()
InputOption::VALUE_NONE,
$this->trans('commands.generate.entity.content.options.is-translatable')
);

$this->addOption(
'is-revisionable',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update this option as revisionable instead.

We are planning to update is-translatable as translatable only as well.

@MrDaleSmith
Copy link
Contributor Author

Hi @jmolivas

Rebased and amended the name of the option. Cheers for the feedback :)

@jmolivas
Copy link
Member

jmolivas commented Aug 7, 2016

@pdscti there is still an issue with PHPUnit on the build

https://travis-ci.org/hechoendrupal/DrupalConsole/jobs/149409889#L280

1.71s$ phpunit
PHPUnit 4.5.0 by Sebastian Bergmann and contributors.
Configuration read from /home/travis/build/hechoendrupal/DrupalConsole/phpunit.xml.dist
I................I....................E.......................... 65 / 69 ( 94%)
....
Time: 1.56 seconds, Memory: 34.75Mb
There was 1 error:
1) Drupal\Console\Test\Generator\EntityContentGeneratorTest::testGenerateEntityContent with data set #0 ('Foo', 'foo938160895', 'Bar', 'bar', 'admin/structure', 'true')
Missing argument 7 for Drupal\Console\Test\Generator\EntityContentGeneratorTest::testGenerateEntityContent()
/home/travis/build/hechoendrupal/DrupalConsole/Test/Generator/EntityContentGeneratorTest.php:36

FAILURES!                                            
Tests: 69, Assertions: 105, Errors: 1, Incomplete: 2.

@jmolivas jmolivas modified the milestones: 1.0.0-rc2, 1.0.0-rc1 Aug 7, 2016
@MrDaleSmith
Copy link
Contributor Author

Hi @jmolivas - thought I'd caught all of the changes in the tests, but looks like I missed a couple. Just trying again.

@MrDaleSmith
Copy link
Contributor Author

MrDaleSmith commented Aug 8, 2016

@jmolivas Tests are passing: let me know if I've missed something though: PHP Unit is new to me.

@jmolivas
Copy link
Member

@pdscti looking at this early next week.

@jmolivas
Copy link
Member

jmolivas commented Oct 8, 2016

@pdscti sorry for the late reply, but tagging the RC took longer that expected do you mind to sync your PR to have it merged.

EN translations got moved to this repo => https://github.com/hechoendrupal/drupal-console-en

The rest of the languages will be moved soon.

@MrDaleSmith
Copy link
Contributor Author

@jmolivas I'm doing git merge upstream/master but it's telling me there are no changes to merge in. Am I missing something?

@MrDaleSmith
Copy link
Contributor Author

@jmolivas That got it: I'd lost my remote origin somehow in all the excitement.

@jmolivas
Copy link
Member

@pdscti looking at this today thanks for making the sync

@jmolivas jmolivas merged commit 0dc8f71 into hechoendrupal:master Oct 14, 2016
@jmolivas
Copy link
Member

@pdscti Thanks for your contribution, your PR was merged. This will be included on the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants