Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[container:parameters] Issue #2766: add a container:parameters command. #2768

Merged
merged 1 commit into from Oct 15, 2016

Conversation

fgm
Copy link
Contributor

@fgm fgm commented Oct 5, 2016

Suggested content for console-en / translations / container.parameters.yml:

description: 'Displays current parameters for an application. Internal parameters of Drupal, Console, and the container are excluded for readability.'

@fgm fgm changed the title Issue #2766: add a container:parameters command. [container:parameters] Issue #2766: add a container:parameters command. Oct 5, 2016
@jmolivas jmolivas merged commit 881c0e7 into hechoendrupal:master Oct 15, 2016
@jmolivas
Copy link
Member

@fgm Thanks for your contribution, your PR was merged. This will be included on the next release.

@jmolivas jmolivas modified the milestone: 1.0.0-rc6 Oct 15, 2016
@fgm
Copy link
Contributor Author

fgm commented Oct 15, 2016

Thanks for including it.

@fgm fgm deleted the container-parameters branch October 15, 2016 16:36
@jmolivas
Copy link
Member

@fgm I like the command but not sure about the name yet.

Maybe container:debug:parameters is a better option or do what symfony does add this feature to the container:debug command and use it as container:debug --parameters

@fgm
Copy link
Contributor Author

fgm commented Oct 15, 2016

Yes, I wondered how to name it too: it should basically just be a part of container:debug, but I did not want to modify this existing well-known command. I hadn't thought of the parameters idea: might be the best choice.

@jmolivas
Copy link
Member

@fgm I moved the code to drupal container:debug --parameters

@jmolivas
Copy link
Member

This is the PR #2826 containing the code relocation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants