Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update:execute] Support batch updates and post update functions #4057

Merged
merged 1 commit into from May 23, 2019

Conversation

Projects
None yet
2 participants
@rlmumford
Copy link
Contributor

commented May 22, 2019

See Issue #3929

Problem/Motivation

drupal updb does not support batch updates. This has made updating from 8.6.x - 8.7.0 impossible as several of the post_update functions require batch processing.

Details of how to reproduce can be found on issue #3929

Solution

Update ExecuteCommand::executeUpdate() to loop over the update function until it is completed. Provide helpful feedback to the user throughout this process.

I've added a do { } while() loop into executeUpdate to ensure that the function get's run the correct number of time.

A default message of 'Processed x%' is printed as information and indented to make clear that it relates to the function above.

batchupdatefunction

@enzolutions

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

Thanks, @rlmumford for your contribution.

Do you think you can help us with these issues related #3929 , #3574 and #3787

@enzolutions enzolutions merged commit db15e4e into hechoendrupal:master May 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.