Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#493 DefaultController routing.yml prepend a leading forward slash #494

Conversation

kenneth-bolivar-castro
Copy link
Contributor

DefaultController routing.yml prepend a leading forward slash to path property

@jmolivas
Copy link
Member

jmolivas commented Mar 6, 2015

Awesome @kenneth-bolivar-castro, since you are working on this issue may you care about doing the same fix on the ControllerGenerator
Probably asking if $route value does not start with / then prepend it
https://github.com/hechoendrupal/DrupalAppConsole/blob/master/src/Generator/ControllerGenerator.php#L20

jmolivas added a commit that referenced this pull request Mar 7, 2015
…ller-routing-yml-path

#493 DefaultController routing.yml prepend a leading forward slash
@jmolivas jmolivas merged commit 4a1f687 into hechoendrupal:master Mar 7, 2015
@jmolivas
Copy link
Member

jmolivas commented Mar 7, 2015

Thanks for the PR @kenneth-bolivar-castro
I added a related issue #495 to fix the same on generate:controller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants