Enhancement permission generator

[omero]

No description provided.

[omero]

PR for #506
if i'm not wrong @esod wrote this command, do you have any suggestions, something we can do better or something isn't necessary ?

[jmolivas]

Looks good to me any comments ?

[esod]

Nice. The changes improve the flow of the script and it's great to see the script making additions to existing permissions.yml files.

I think restrict access should be either true, false, or none. none is something I'm working on with the install generator if I can ever get the test to pass...

On line 53 of PermissionTrait.php

• $title = $this->getStringUtils()->camelCaseToUcFirst($title);
• $title = $this->getStringUtils()->anyCaseToUcFirst($title);

camelCaseToUcFirst() doesn't exist unless it's in another branch. I wrote anyCaseToUcFirst() in StringUtils.php for the permission_title. I thought title: needed to be identical to the permission except for the UC first, so I used application code to generate it. But I see in book.permissions.yml that the permission and the title don't need to be identical:

I can't be sure, exactly, since I only knew to cut and paste the changes into my local console.dev, but I'd check the twig templates to make sure the indents are correct.

[omero]

Thanks for the comments @esod, i did the changes that you suggest ... camelCaseToUcFirst() exist in the master branch https://github.com/hechoendrupal/DrupalAppConsole/blob/master/src/Utils/StringUtils.php#L86 , I not see the anyCaseToUcFirst() but i rename the function in this PR, I agree that the function can apply for any, and not exclusive for camel case

[jmolivas]

Thanks for the PR @omero and the provided help @esod