Implement font rendering for wgpu backend
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Powered by `wgpu_glyph`.
hecrj
commented
Apr 28, 2019
| @@ -128,6 +128,8 @@ impl Gpu { | |||
| font: &mut Font, | |||
| target: &TargetView, | |||
| depth: &DepthView, | |||
| _target_width: u32, | |||
| _target_height: u32, | |||
There was a problem hiding this comment.
I think glyph_brush can be improved to be target size agnostic. I will try to make a PR to glyph_brush with the idea, but there will be breaking changes.
If all goes well, it should allow us to support font rendering on any Target, with custom Transformation support.
There was a problem hiding this comment.
Related issue: alexheretic/glyph-brush#63.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5.
This was pretty straightforward to integrate. I have:
wgpu_glyphas a dependency.gpu::Fontfor thewgpu_backend. The implementation is very similar to thegfxbackend.The hardest part was writing
wgpu_glyph, which still needs some improvements.Currently, there are differences between
gfxandwgpufont rendering. I suspect it is related to the way we deal (or do not deal) with gamma correction. I will open a new issue to further investigate this.