Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Task consistency #66

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Improve Task consistency #66

merged 2 commits into from
Jul 3, 2019

Conversation

hecrj
Copy link
Owner

@hecrj hecrj commented Jul 3, 2019

Fixes #61.

Added

  • Task::succeed replaces the old Task::new.

Changed

  • Task::new now supports a lazy operation that can fail.

@hecrj
Improve Task consistency.
523074b 
  - Rename `Task::new` to `Task::succeed`
  - Make `Task::new` lazy operation return a `coffee::Result`
@hecrj hecrj added the feature New feature or request label Jul 3, 2019
@hecrj hecrj self-assigned this Jul 3, 2019
@hecrj hecrj merged commit 1bfb156 into master Jul 3, 2019
@hecrj hecrj deleted the feature/task-consistency branch July 5, 2019 18:24
@hecrj hecrj added this to the 0.4.0 milestone Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hecrj hecrj

Labels
feature New feature or request
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Should Task::new expect a result?
1 participant
@hecrj