Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track more inputs in KeyboardAndMouse #67

Merged
merged 2 commits into from
Jul 8, 2019

Conversation

DarkDrek
Copy link
Contributor

@DarkDrek DarkDrek commented Jul 7, 2019

Implementation for #64

Now KeyboardAndMouse can

  • Handle other mouse buttons than Left
  • Track mouse wheel movements
  • Detect cursor leaving game window

I decided against keeping the old interface so this is a breaking change.
Is it correct / convenient to track the mouse wheel movements as a point?

Handle other mouse buttons than Left
Track mouse wheel movements
Detect cursor leaving game window
Copy link
Owner

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work here! 🎉 Thank you for this!

Just a couple of small details to address before merging. 🚀

src/input/keyboard_and_mouse.rs Outdated Show resolved Hide resolved
src/input/keyboard_and_mouse.rs Outdated Show resolved Hide resolved
src/input/keyboard_and_mouse.rs Outdated Show resolved Hide resolved
src/input/keyboard_and_mouse.rs Outdated Show resolved Hide resolved
Use mouse in name of mouse functions
Fix use of self.is_cursor_taken
Copy link
Owner

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you again 🎉

@hecrj hecrj merged commit 98d65db into hecrj:master Jul 8, 2019
@DarkDrek DarkDrek deleted the track-more-input branch July 9, 2019 05:24
@hecrj hecrj added the feature New feature or request label Jul 10, 2019
@hecrj hecrj added this to the 0.4.0 milestone Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants