Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Transformation::transform_point/vector and inverse. Add From/Into… #78

Merged
merged 6 commits into from
Jul 29, 2019
Merged

Add Transformation::transform_point/vector and inverse. Add From/Into… #78

merged 6 commits into from
Jul 29, 2019

Conversation

PvdBerg1998
Copy link
Contributor

… nalgebra::Projective2

Fixes #76.

@PvdBerg1998
Copy link
Contributor Author

PvdBerg1998 commented Jul 28, 2019 •
edited
Loading

Do not merge yet

Ready to go!

hecrj
hecrj requested changes Jul 28, 2019
View reviewed changes
src/graphics/transformation.rs Outdated Show resolved Hide resolved
src/graphics/transformation.rs Show resolved Hide resolved
hecrj
hecrj approved these changes Jul 29, 2019
View reviewed changes
Copy link
Owner

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to get Transformation to use a Matrix3 instead of a Matrix4.

Thank you!

@hecrj hecrj merged commit 00c8495 into hecrj:master Jul 29, 2019
@hecrj hecrj added feature New feature or request improvement An internal improvement labels Jul 29, 2019
@hecrj hecrj added this to the 0.4.0 milestone Jul 29, 2019
@PvdBerg1998 PvdBerg1998 deleted the issue76 branch October 7, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
feature New feature or request improvement An internal improvement
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Additional functionality for Transformation
2 participants
@PvdBerg1998 @hecrj