Proven that locks are broken due to incorrect ack check ordering.

hector-client · Nov 3, 2012 · dff96df · dff96df
1 parent e9733fc
commit dff96df
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/core/src/main/java/me/prettyprint/cassandra/locking/HLockManagerImpl.java b/core/src/main/java/me/prettyprint/cassandra/locking/HLockManagerImpl.java
@@ -147,6 +147,15 @@ public void acquire(HLock lock, long timeout) {
       canBeEarlier = readExistingLocks(lock.getPath(), canBeEarlierSortedList);
     }
 
+    if(logger.isDebugEnabled()){
+      List<String> canBeEarlierSortedList = Lists.newArrayList(canBeEarlier.keySet());
+      // sort them
+      Collections.sort(canBeEarlierSortedList);
+
+      String peers = Joiner.on(", ").join(canBeEarlierSortedList);
+      logger.debug("{} acquired lock.  Peers are {}", lock, peers);
+    }
+
     ((HLockImpl) lock).setAcquired(true);
   }
 

diff --git a/core/src/test/resources/log4j.xml b/core/src/test/resources/log4j.xml
@@ -6,10 +6,10 @@
 			<param name="ConversionPattern" value="%d{ABSOLUTE} %5p %c{1}:%L - %m%n" />
 		</layout>
 	</appender>
-	<!-- <logger name="me.prettyprint.cassandra.locking">
+	 <logger name="me.prettyprint.cassandra.locking" additivity="false">
 		<level value="debug" />
 		<appender-ref ref="stdout" />
-	</logger> -->
+	</logger>
 	<root>
 		<priority value="info"></priority>
 		<appender-ref ref="stdout" />