Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for merging lazy partnered schemas #147

Merged
merged 10 commits into from
May 17, 2024

Conversation

happy5214
Copy link
Member

@happy5214 happy5214 commented Apr 19, 2024

This PR implements support for merging partnered schemas with the same withStandard XML attribute into the same Schema object, thereby treating them as a single schema. It provides the required validation of schema compatibility, the code to actually merge the data, and tests.

@happy5214 happy5214 added bids BIDS integration hed 3 HED 3-specific issues schema Schema parsing important Important issues labels Apr 19, 2024
@happy5214 happy5214 added this to the 3.14.0 milestone Apr 19, 2024
@happy5214 happy5214 self-assigned this Apr 19, 2024
@happy5214 happy5214 linked an issue Apr 19, 2024 that may be closed by this pull request
@happy5214 happy5214 added the enhancement New feature or request label Apr 19, 2024
@happy5214 happy5214 marked this pull request as ready for review May 10, 2024 14:36
@happy5214 happy5214 requested a review from VisLab May 10, 2024 14:36
Copy link
Member

@VisLab VisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes were more substantial than I had first thought --- but it looks good.

@happy5214 happy5214 merged commit 8221e32 into master May 17, 2024
7 checks passed
@happy5214 happy5214 deleted the lazy-partnered-schemas branch May 17, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bids BIDS integration enhancement New feature or request hed 3 HED 3-specific issues important Important issues schema Schema parsing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement merging of partnered schemas
2 participants