You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The HED validator is not correctly detecting duplicate tags that are extensions.
Example:Attribute/Red has no validation errors. Short-to-long conversion correctly detects the error:
Unable to convert HED string:
ERROR: 'Red' appears as 'Attribute/Sensory/Visual/Color/CSS-color/Red-color/Red' and cannot be used as an extension. 10, 13
Here is how I think this should be handled on validation.
No duplicate tags should ever allowed as extensions regardless of HED version. HED-2G and HED-3G both have Red in their hierarchy so Attribute/Red would always be an error regardless of HED version.
Tag extensions would always generate a warning, so Attribute/Bananas would always generate a warning regardless of the version since Bananas is a tag extension.
I think that putting in the restriction that tag extensions can't be in the hierarchy already simplifies the logic. @IanCa@happy5214
The text was updated successfully, but these errors were encountered:
The HED validator is not correctly detecting duplicate tags that are extensions.
Example:
Attribute/Red
has no validation errors. Short-to-long conversion correctly detects the error:Here is how I think this should be handled on validation.
Red
in their hierarchy soAttribute/Red
would always be an error regardless of HED version.Attribute/Bananas
would always generate a warning regardless of the version sinceBananas
is a tag extension.I think that putting in the restriction that tag extensions can't be in the hierarchy already simplifies the logic.
@IanCa @happy5214
The text was updated successfully, but these errors were encountered: