Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator is not detecting duplicate tags #189

Closed
VisLab opened this issue Apr 3, 2021 · 2 comments
Closed

Validator is not detecting duplicate tags #189

VisLab opened this issue Apr 3, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@VisLab
Copy link
Member

VisLab commented Apr 3, 2021

The HED validator is not correctly detecting duplicate tags that are extensions.

Example: Attribute/Red has no validation errors. Short-to-long conversion correctly detects the error:

Unable to convert HED string:
ERROR: 'Red' appears as 'Attribute/Sensory/Visual/Color/CSS-color/Red-color/Red' and cannot be used as an extension. 10, 13

Here is how I think this should be handled on validation.

  1. No duplicate tags should ever allowed as extensions regardless of HED version. HED-2G and HED-3G both have Red in their hierarchy so Attribute/Red would always be an error regardless of HED version.
  2. Tag extensions would always generate a warning, so Attribute/Bananas would always generate a warning regardless of the version since Bananas is a tag extension.

I think that putting in the restriction that tag extensions can't be in the hierarchy already simplifies the logic.
@IanCa @happy5214

@VisLab VisLab added the bug Something isn't working label Apr 5, 2021
@IanCa
Copy link
Member

IanCa commented Apr 17, 2021

  1. Should now be fixed with the new pull request.
  2. Is not yet handled.

@IanCa
Copy link
Member

IanCa commented Aug 19, 2021

This should be resolved as of a while ago.

@IanCa IanCa closed this as completed Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants