Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom kebab-case html tags #8

Merged
merged 1 commit into from
Nov 10, 2015
Merged

Support custom kebab-case html tags #8

merged 1 commit into from
Nov 10, 2015

Conversation

aidistan
Copy link
Contributor

Close #7

@aidistan
Copy link
Contributor Author

The syntax highlight still breaks when custom tags start with any meta.tag.block.any.html or meta.tag.inline.any.html.

hedefalk added a commit that referenced this pull request Nov 10, 2015
Support custom kebab-case html tags
@hedefalk hedefalk merged commit 6f69ed8 into hedefalk:master Nov 10, 2015
@hedefalk
Copy link
Owner

lgtm!

@aidistan
Copy link
Contributor Author

We could add (?!-) to following lines to fix custom tag highlight completely, but I have no idea how to fix the indent issue reported in #7.

@hedefalk
Copy link
Owner

@aidistan Cool! Please PR any additional things you want and I'll publish to apm as quick as I can. I'm at bit too busy too look into anything myself right now though. If I'm too slow and you want, I can give you push access?

@TheWaWaR
Copy link

image

After use your patch:

  1. Auto indent still not working
  2. grid-view matched the highlight, but base-view does not
    • I think it's because of below code matched the base-view first:
// Line: 402
{
  begin: "(</?)((?i:a|abbr|acronym|area|b|base|basefont|bdo|big|br|button|caption|cite|code|col|colgroup|del|dfn|em|font|head|html|i|img|input|ins|isindex|kbd|label|legend|li|link|map|meta|noscript|optgroup|option|param|q|s|samp|script|select|small|span|strike|strong|style|sub|sup|table|tbody|td|textarea|tfoot|th|thead|title|tr|tt|u|var)\\b)"
}

@aidistan aidistan deleted the patch-1 branch November 10, 2015 12:23
@aidistan
Copy link
Contributor Author

@TheWaWaR The highlight was fixed in #9, but the indent issue remains.

I have reproduced the situation in language-html, which proves the issue is not related to this package.

selection_002

@aidistan
Copy link
Contributor Author

@TheWaWaR Additionally, I would like to suggest you to use Jade in templates.

Life is short, why not to use a template language to save it ? 😄

@hedefalk
Copy link
Owner

0.5 published with this PR.

@TheWaWaR
Copy link

Jade can't auto indent~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants